Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): add aria-* entries to interface settings #2799

Merged
merged 3 commits into from
Apr 13, 2024
Merged

fix(a11y): add aria-* entries to interface settings #2799

merged 3 commits into from
Apr 13, 2024
+67 −61

Conversation

userquin
Copy link
Member

No description provided.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit e827307
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/661a5d85a2c1f400083b71e6
😎 Deploy Preview https://deploy-preview-2799--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit e827307
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/661a5d85e4aa0d000874aee9

shuuji3
shuuji3 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shuuji3
Copy link
Member

shuuji3 commented Apr 13, 2024 •
edited
Loading

This fix includes #2771

@shuuji3 shuuji3 force-pushed the userquin/fix-a11y-interface-settings branch from 991ed4a to 15d4966 Compare April 13, 2024 10:09
@shuuji3 shuuji3 force-pushed the userquin/fix-a11y-interface-settings branch from 15d4966 to a1621fd Compare April 13, 2024 10:10
@patak-dev patak-dev added this pull request to the merge queue Apr 13, 2024
@shuuji3 shuuji3 removed this pull request from the merge queue due to a manual request Apr 13, 2024
@userquin
Copy link
Member Author

userquin commented Apr 13, 2024 •
edited
Loading

I'll review the index.vue later (sending another PR), we should use some semantic tags like section moving the p inside the SettingXXX using some heading like h2 + some aria-* attr

@shuuji3 shuuji3 added this pull request to the merge queue Apr 13, 2024
Merged via the queue into main with commit 6bb9ad0 Apr 13, 2024
15 checks passed
@shuuji3 shuuji3 deleted the userquin/fix-a11y-interface-settings branch April 13, 2024 10:42
@userquin
Copy link
Member Author

@shuuji3 if you are using mac, you can activate/deactivate VoiceOver with command+f5, check Introducing VoiceOver

@shuuji3
Copy link
Member

shuuji3 commented Apr 13, 2024

@userquin Thanks for the info. I'll give it a try as well as Android's similar feature 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuuji3 shuuji3 shuuji3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@userquin @shuuji3