fix: list name is not up-to-date after modification #2797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Screen.Recording.2024-04-11.at.7.15.46.PM.mov
As you can see from this screenrecord, the name is always out-of-date.
After:
Screen.Recording.2024-04-11.at.7.16.41.PM.mov
CommonPaginator triggered updateEntry once a new list value is assigned.
elk/components/common/CommonPaginator.vue
Lines 60 to 64 in 706cffe
The cancelEdit will trigger a
reset
but at that time,list.value
is still holding an old value. This pr just moves thereset
after nextTick to ensure the value is up-to-date.elk/components/list/ListEntry.vue
Lines 43 to 46 in 706cffe