Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide duplicated status actions items on details page in zen mode #2731

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Apr 1, 2024

When enabled in the zen mode, the more actions menu shows the hidden action items such as "Reply" and "Boost". However, in the details page, the action footer is shown by default so we don't have to include these items in the more actions menu.

This PR hides these items only within the details page. The items in the home timeline remain the same.

More actions in home timeline

No bottom actions so the more actions menu has items.
Screenshot from 2024-04-01 11-27-08

More actions in details page

Before

Both the bottom actions footer and the more actions menu has the same set of items, which are duplicated.

Screenshot from 2024-04-01 11-26-34

After

Screenshot from 2024-04-01 11-26-25

Copy link

stackblitz bot commented Apr 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 8a85b6b
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/660a2ad9387d830008134046

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 8a85b6b
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/660a2ad9a4a13a0008749b70
😎 Deploy Preview https://deploy-preview-2731--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev patak-dev added this pull request to the merge queue Apr 1, 2024
Merged via the queue into main with commit d8d9975 Apr 1, 2024
18 checks passed
@patak-dev patak-dev deleted the shuuji3/fix/hide-action-items-in-zen-mode branch April 1, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants