Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent hover highlight styling in mobile bottom navigation menus #2661

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Mar 7, 2024

fix #2656

Adopted the same hover highlight style as the bottom two items like the Zen mode menu.

Screenshots

Light mode

Dark mode

Before

In dark mode, the highlight was really hard to see:

Screenshot from 2024-03-08 00-25-37

Copy link

stackblitz bot commented Mar 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit b6267bd
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65e9dbc975d08a0008e7defb

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit b6267bd
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65e9dbc964845800085c85dc
😎 Deploy Preview https://deploy-preview-2661--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3 shuuji3 marked this pull request as draft March 7, 2024 15:12
@shuuji3 shuuji3 force-pushed the fix/consistent-mobile-bottom-navigation-style branch from 36ca433 to fbbb351 Compare March 7, 2024 15:22
@shuuji3 shuuji3 force-pushed the fix/consistent-mobile-bottom-navigation-style branch from fbbb351 to b6267bd Compare March 7, 2024 15:22
@shuuji3 shuuji3 marked this pull request as ready for review March 7, 2024 15:24
@shuuji3 shuuji3 changed the title fix: consistent background highlight styling in mobile bottom navigation menus fix: consistent hover highlight styling in mobile bottom navigation menus Mar 7, 2024
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@patak-dev patak-dev added this pull request to the merge queue Mar 7, 2024
Merged via the queue into elk-zone:main with commit efa17ca Mar 7, 2024
15 checks passed
@shuuji3 shuuji3 deleted the fix/consistent-mobile-bottom-navigation-style branch March 7, 2024 23:54
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom navigation items have narrow background highlight in mobile view
2 participants