feat: allow to scroll-to-top by clicking header title in account, list, and tag pages #2635
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think this is a good change, but we should first fix an issue with the back arrow as it will happen after this PR in more cases. The back arrow should only be there if there is history inside the page to navigate, if not we shouldn't show it. For example, I think the arrow shouldn't appear if I visit this link: https://deploy-preview-2635--elk-zone.netlify.app/universeodon.com/@elkdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elk, we can click the title to scroll to the top pages. This is useful after reading many posts. But some pages don't have this feature and the title text style was inconsistent.
This RP ensures that three pages (user account, list, tag) have this feature. All of them usually have many posts so the scroll-to-top feature should be useful too.
User account page
https://deploy-preview-2635--elk-zone.netlify.app/universeodon.com/@elkdev
(note: title is not shown in wider screen size)
Before
After
List page
https://deploy-preview-2635--elk-zone.netlify.app/universeodon.com/list/2769
Before
After
Hashtag page
https://deploy-preview-2635--elk-zone.netlify.app/tags/elk
Before
After