Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add several new shortcut keys for navigation #2618

Merged

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 24, 2024

This PR implements most of the navigation shortcuts in #1855.

Before
image

After
Screenshot from 2024-02-25 03-43-29

These had already been implemented:

  • g+h - Home
  • g+n - Notifications

New shortcuts by this PR:

Remaining:

  • g+u - Go to User (focus on search with '@')

Copy link

stackblitz bot commented Feb 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit f78ee8d
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65da38f2bc0121000868690d

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f78ee8d
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65da38f25815050009fec843
😎 Deploy Preview https://deploy-preview-2618--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev
Copy link
Member

Sweet!

@shuuji3
Copy link
Member Author

shuuji3 commented Feb 24, 2024

Forgot to mention that the "g+c - Conversations" is currently overridden by c (compose): https://github.com/elk-zone/elk/pull/2618/files#diff-056fa2fefde5dfe10f592f8bd1407e39e7a9347261dcad084fea60d2eae03e9cR42-R43 (though sometimes works due to the current issue we found in #2612).

To fix this, we'll need to find a way to avoid activating c when the first key (g) has already been typed.

@patak-dev patak-dev added this pull request to the merge queue Feb 24, 2024
Merged via the queue into elk-zone:main with commit edcc874 Feb 24, 2024
14 checks passed
@shuuji3 shuuji3 deleted the feat/add-several-shortcut-keys-for-navigation branch February 25, 2024 04:43
@joelanman
Copy link

might this have caused this issue?
#2628

shuuji3 added a commit to shuuji3/elk that referenced this pull request Feb 29, 2024
shuuji3 added a commit to shuuji3/elk that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants