Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Bluesky and Friendica icons #2563

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Jan 18, 2024

This implements additional two icons (Bluesky and Friendica) for #2472

Copy link

stackblitz bot commented Jan 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit e916fb5
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65a8e33fddef260008cc745c

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit e916fb5
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65a8e33f4c1ab90008905a82
😎 Deploy Preview https://deploy-preview-2563--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3 shuuji3 force-pushed the feat/add-bluesky-and-frendica-icons branch from efc024e to 179fba6 Compare January 18, 2024 08:10
@patak-dev
Copy link
Member

Something is odd, in the Netlify preview link the new icons aren't rendering
image

@shuuji3
Copy link
Member Author

shuuji3 commented Jan 18, 2024

Sorry, I simply forgot to include package.json update when handling multiple branches 🙏🏻

@shuuji3 shuuji3 force-pushed the feat/add-bluesky-and-frendica-icons branch from 3af8312 to e916fb5 Compare January 18, 2024 08:37
@shuuji3
Copy link
Member Author

shuuji3 commented Jan 18, 2024

You should be able to see the icons in Netlify preview now. Maybe cache clear is needed.

Screenshot from 2024-01-18 17-40-11

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@patak-dev patak-dev added this pull request to the merge queue Jan 18, 2024
Merged via the queue into elk-zone:main with commit cadf1b4 Jan 18, 2024
13 checks passed
@shuuji3 shuuji3 deleted the feat/add-bluesky-and-frendica-icons branch January 18, 2024 12:19
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants