fix: spoiler button style in notifications #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HawtinZeng
pushed a commit
to HawtinZeng/elk
that referenced
this pull request
Jan 7, 2024
maybeanerd
pushed a commit
to maybeanerd/crab
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At
Homepage, it has no contrast with pages background since they're bothbase. But at notification page, there's difference between them.This pull request set the button as
rounded-lgto make the button have a better appearance. But I'm not sure if the button's background should be always transparent, since it will be transparent when the post is a DM.Without hover
Dark
Light
Hover, Before
Dark
Light
Hover, After
Dark
Light