Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Threads icon in profile links #2474

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Nov 16, 2023

This adds Threads icon support in the links of the profile page.

partially implements #2472 (only Threads icon)

Copy link

stackblitz bot commented Nov 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 72f9473
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6556e46a7dad010008820d6c

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 72f9473
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6556e46a108b2d000895b616
😎 Deploy Preview https://deploy-preview-2474--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3 shuuji3 marked this pull request as draft November 16, 2023 15:51
@shuuji3
Copy link
Member Author

shuuji3 commented Nov 16, 2023

It looks like I need additional changes to include the actual icon data (will update later).

Screenshot from 2023-11-17 00-52-35

@shuuji3 shuuji3 marked this pull request as ready for review November 17, 2023 08:23
@shuuji3
Copy link
Member Author

shuuji3 commented Nov 17, 2023

Threads icon was added in remix icon v3.5.0 but the current version was v3.4.0, which is installed via @iconify/json. Upgrading that version solved the issue.

Screenshot from 2023-11-17 13-02-43
Screenshot from 2023-11-17 11-49-24

@patak-dev patak-dev added this pull request to the merge queue Nov 17, 2023
Merged via the queue into elk-zone:main with commit 20c30e9 Nov 17, 2023
14 checks passed
@shuuji3 shuuji3 deleted the feat/add-new-profile-icon branch November 17, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants