feat: put account name copy button #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
force-pushed
the
feat/copy-username
branch
from
bd37a94
to
6b57010
Compare
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
force-pushed
the
feat/copy-username
branch
from
6b57010
to
4f17c41
Compare
ryanccn
requested changes
Nov 5, 2023
components/account/AccountHeader.vue
Outdated
| <div flex items-center gap-1> | ||
| <AccountHandle :account="account" overflow-unset line-clamp-unset /> | ||
| <CommonTooltip placement="bottom" :content="$t('account.copy_account_name')" no-auto-focus flex> | ||
| <button text-secondary-light text-sm i-ri:file-copy-line @click="copyAccountName"> |
There was a problem hiding this comment.
Would be great if the button had some sort of response, like changing the icon to a checkmark and changing back after a few seconds.
There was a problem hiding this comment.
Thank you for the review.🙂 That's a good suggestion. I modified it to show a check mark for 2 seconds.
shuuji3
force-pushed
the
feat/copy-username
branch
from
550ac95
to
d27603a
Compare
shuuji3
force-pushed
the
feat/copy-username
branch
from
d27603a
to
f120cc2
Compare
|
New check mark after clicking: copy-check.mp4 |
ryanccn
approved these changes
Nov 14, 2023
patak-dev
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one option to solve #2199. Please see the issue for details and other options.