-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add zen mode to preferences, remove shortcut #2003
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks @manuq! It works nicely! There is only one issue I found while testing. Before you press the |
Good catch @patak-dev ! It turns out that all preferences started as |
The flash was reduced but it is still there. You can compare reloading against elk.zone to see it. |
@manuq starting dev server from scratch using your branch using zen mode by default ( EDIT: using the preview in Windows FF and Chrome working... |
On my local there is no flash (also using PR preview), maybe missing transition? I see a fade-out transition when activating zen mode while deactivating, it is almost instant. |
Ok, I can't reproduce locally. Let's try it out, and we fix it if not later one |
Fixes #1883