You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From @patak-dev 's idea (see here), I adjusted the wellbeing "Hide following/follower count" feature.
Before changes, when "Hide following/follower count" is enabled, the following count and the follower count are hidden as shown below.
After changes, when "Hide following/follower count" is enabled, only the numbers are hidden. The text "Following" and "Followers" are kept so that users are still able to click them to view the following list and the follower list.
We could avoid showing Following/Followers when you are out of the profile (so it doesn't show when hovering on an avatar for example)
I think it is better to have new keys for Following/Followers without a number or force it to use the plural form to avoid seeing Follower if there is only 1.
In the AccountPostFollowers component, I added a props isHoverCard which is set to be true by AccountHoverCard so that "Following" and "Followers" will be further hidden in hover card.
In the LocalizedNumber component, force the plural form when the count is hidden, by :plural="hideNumber ? 2 : count".
You are right. Simply taking away the number may not work in some languages. I changed to re-use account.following and account.followers when counts are hidden. These two keys are used as html title after clicking "Following"/"Followers". I think it makes sense to share same text between the button and the page title after clicking the button.
Besides that, I found that when I click "XX Posts", "XX Following" and "XX Followers" back and forth, the page title only changes once for each one. I will create another issue about that later.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it took us some time to merge this one. Looks great to me now! Thanks for implementing the feature.
patak-dev
changed the title
chore: Allow user to view follow list in "Hide following/follower count" mode
feat: allow user to view follow list in "Hide following/follower count" mode
Apr 16, 2023
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patak-dev
changed the title
From @patak-dev 's idea (see here), I adjusted the wellbeing "Hide following/follower count" feature.
Before changes, when "Hide following/follower count" is enabled, the following count and the follower count are hidden as shown below.
After changes, when "Hide following/follower count" is enabled, only the numbers are hidden. The text "Following" and "Followers" are kept so that users are still able to click them to view the following list and the follower list.
