fix(a11y): add aria labels to bottom navigation links #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
patak-dev
approved these changes
Mar 8, 2023
|
@zaidhaan would you send this question also to the #a11y channel in https://chat.elk.zone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1422.
Only thing left would be making the last item (more menu) focusable (and presumably toggle-able using Space/Enter?). I'm not too experienced with a11y but I've observed the following when making changes to the
<label>in the more menu:role="button"allows using Space/Enter to toggle on Firefox 110.0. But does not make it focusabletabindex="0"makes it focusable / tab accessible but hitting Space/Enter no longer triggers a toggleMaybe someone could suggest/co-author the proper fix for the more menu so that the linked issue could be closed, or we could just merge this now and address that later.