Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): update Japanese localization #1775

Merged
merged 3 commits into from
Feb 18, 2023
Merged

feat(i18n): update Japanese localization #1775

merged 3 commits into from
Feb 18, 2023

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 17, 2023

This PR updates the Japanese localization with the latest en.json.

@kazupon レビューお願いします。今回も新規テキストの追加のみで、新しいデータセーバー機能のテキストと、細かなUIの改善が含まれています。

@stackblitz
Copy link

stackblitz bot commented Feb 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for elk-docs ready!

Name Link
🔨 Latest commit 27813e1
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63f05733e3dce60008cdd613
😎 Deploy Preview https://deploy-preview-1775--elk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 27813e1
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63f057330256df000819e894
😎 Deploy Preview https://deploy-preview-1775--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shuuji3
Copy link
Member Author

shuuji3 commented Feb 17, 2023

1つ翻訳忘れがあったので追加で翻訳しました。

Copy link
Contributor

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます! 💯 です。

@kazupon
Copy link
Contributor

kazupon commented Feb 18, 2023

@patak-dev @danielroe
You can merge this PR.
Sorry for pinging you again.
(I wish I have merge permission ... 😅)

@patak-dev
Copy link
Member

Thanks! Dont worry about the ping 😊

@patak-dev patak-dev merged commit 3ad0abc into elk-zone:main Feb 18, 2023
emanuelpina pushed a commit to emanuelpina/elk that referenced this pull request Feb 18, 2023
@shuuji3 shuuji3 deleted the feat/i18n-update-japanese branch February 19, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants