Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add missing Polish (and English) translation entries #1669

Merged
merged 4 commits into from
Feb 12, 2023

Conversation

Glaydus
Copy link
Contributor

@Glaydus Glaydus commented Feb 8, 2023

No description provided.

@stackblitz
Copy link

stackblitz bot commented Feb 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit d75a898
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63e8f0aa2917720008ea295f

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit d75a898
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63e8f0aa7058180008e903d6
😎 Deploy Preview https://deploy-preview-1669--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Glaydus
Copy link
Contributor Author

Glaydus commented Feb 8, 2023

Adding missing translations (including English).
Minor tweaks to SettingsProfileMetadata.vue were required.

@Glaydus Glaydus changed the title feat(i18n): add missing Polish translation entries feat(i18n): add missing Polish (and English) translation entries Feb 8, 2023
input-base
>
<input
v-model="form.fieldsAttributes[i - 1].value"
type="text" placeholder="Content"
type="text" placeholder-text-secondary
:placeholder="$t('settings.profile.appearance.profile_metadata_value')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@userquin would you add a comment to this PR showing how you would like we announce these two new key?

Copy link
Member

@userquin userquin Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should be this:

New entries to translate (only included in en and pl-PL):

  • settings.profile.appearance.profile_metadata_label
  • settings.profile.appearance.profile_metadata_value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to copy the source message and paste it on i18n channel.

@patak-dev patak-dev merged commit f295ddb into elk-zone:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants