-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle frozen page lifecycle state #1658
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
We need to resolve the EDIT: maybe we can keep current code (just remove the comment and undo moving |
Works fine on Android! It seems this PR fixes Firefox problem: |
Don't merge yet, we're preparing final test on iOS emulator to confirm it is working. |
@danielroe this is ready, on iOS emulator, the prompt for update seems to be not working, but it works for new toots once the installed PWA minimized for 10 minutes. |
Tested in iOS 16.2, app working normally, except for update as @userquin mentioned. Not seeing update notification anywhere. edit: actually, not normally. Some menu items don't work: settings, lists, federated, local. After restarting phone everything started working again. Settings showed that app uses latest commit, so app was updated at some point without prompt (it was installed before last commit). |
@danielroe just added the plugin, we'll need to close all
database
andwss
connections : for reference check Frozen state here https://developer.chrome.com/blog/page-lifecycle-api/#developer-recommendations-for-each-statecloses #750
closes #1584