Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add zh-TW translation #1628

Merged
merged 8 commits into from
Feb 13, 2023
Merged

feat(i18n): add zh-TW translation #1628

merged 8 commits into from
Feb 13, 2023

Conversation

benben6515
Copy link
Contributor

@benben6515 benben6515 commented Feb 5, 2023

add some zh-TW first, when I have more time I will be back!


  • 2023/02/05 updated

  • Translated zh-TW 100% for now :D

If the core team wants to change some of them for good, go for it. Maybe I just add rough translations.

@stackblitz
Copy link

stackblitz bot commented Feb 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 5, 2023

Deploy Preview for elk-docs ready!

Name Link
🔨 Latest commit e966d76
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63e086141c70cf0008e0bc5d
😎 Deploy Preview https://deploy-preview-1628--elk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 5, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit e966d76
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63e086149cbd7b0008bceef7
😎 Deploy Preview https://deploy-preview-1628--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@benben6515 benben6515 changed the title update(i18n): add some zh-TW feat(i18n): add some zh-TW Feb 5, 2023
@benben6515 benben6515 changed the title feat(i18n): add some zh-TW feat(i18n): add zh-TW translation Feb 5, 2023
@antfu antfu requested a review from a team February 5, 2023 12:19
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-TW.json Outdated Show resolved Hide resolved
benben6515 and others added 5 commits February 6, 2023 08:05
change `倉庫` to `儲存庫`
remove some key not use in Elk
Copy link
Member

@Mini-ghost Mini-ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xatier
Copy link

xatier commented Feb 7, 2023

@benben6515 FYI, related PR #1617

@benben6515
Copy link
Contributor Author

@xatier Thank you for sharing this information. Honestly, '您' and '你' both work to me.
Therefore, I think we just provide references and let elk team decide which one. 🫡

@xatier
Copy link

xatier commented Feb 8, 2023

@benben6515 exactly, the existing zh-tw translation is using a mixed tone, which we should really make it consistent. Once the elk team picks a choice, let's update this PR.

@antfu antfu merged commit 379f567 into elk-zone:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants