fix: undo changes on push notifications settings stops working

[userquin]

Vueuse history stops working.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[netlify]

✅ Deploy Preview for elk-docs canceled.

Name	Link
🔨 Latest commit	2ff50f5
🔍 Latest deploy log	https://app.netlify.com/sites/elk-docs/deploys/63dd2e4e5c340200084aa76e

[netlify]

✅ Deploy Preview for elk-zone ready!

Name	Link
🔨 Latest commit	2ff50f5
🔍 Latest deploy log	https://app.netlify.com/sites/elk-zone/deploys/63dd2e4eadff34000879a37d
😎 Deploy Preview	https://deploy-preview-1599--elk-zone.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[patak-dev]

I think we can merge this now. But is there a reason for these settings to work in a different way from all the others? Why are we allowing the user to cancel here? In all other settings screens, we apply the modification and move on. Should we also do the same here?

[userquin]

I think we can merge this now. But is there a reason for these settings to work in a different way from all the others? Why are we allowing the user to cancel here? In all other settings screens, we apply the modification and move on. Should we also do the same here?

All these settings are saved on backend, mastodon rn just send a request per check changed, we allow send all at once: that's why I included undo.

[patak-dev]

Ah, I see we also do the same for the Profile. Is it costly to do multiple requests? I think it may be better to just do the changes with out the save. But ya, ignore my prev comment because this is now the pattern we use for other things too.

[userquin]

Is it costly to do multiple requests?

Yes, but also a11y, doing requests on check change is not good, we use a form with checkboxes and the policy html select.