Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lists link on side nav #1596

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: lists link on side nav #1596

merged 1 commit into from
Feb 3, 2023

Conversation

edimitchel
Copy link
Collaborator

The list side nav item is pointing to the wrong link, also, you could have redirection to home when opening in a new tab:

ACTUAL
list-link-issue

FIXED
list-link-issue-fixed

@edimitchel edimitchel added the p: 2-high Fix main branch label Feb 3, 2023
@edimitchel edimitchel requested review from userquin and a team February 3, 2023 13:53
@stackblitz
Copy link

stackblitz bot commented Feb 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 3, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 9812835
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63dd11c233b8f400083334cf

@netlify
Copy link

netlify bot commented Feb 3, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 9812835
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63dd11c2c4ccc800088bacaf
😎 Deploy Preview https://deploy-preview-1596--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@edimitchel edimitchel requested a review from boehs February 3, 2023 13:55
boehs
boehs approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@boehs boehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, behavior, I assumed it would be fine because the link is only for logged in users. LGTM

@patak-dev patak-dev merged commit 6eedaa9 into main Feb 3, 2023
@patak-dev patak-dev deleted the fix/list-link-on-sidenav branch February 3, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@userquin userquin userquin approved these changes

@boehs boehs boehs approved these changes

Assignees
No one assigned
Labels
p: 2-high Fix main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edimitchel @userquin @boehs @patak-dev