fix: character count should includes spoiler text #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielroe
reviewed
Feb 5, 2023
Comment on lines
+29
to
+30
| if (!draft.params.sensitive) | ||
| return |
There was a problem hiding this comment.
Do we need this?
Suggested change
| if (!draft.params.sensitive) | |
| return |
There was a problem hiding this comment.
No, just to make the logic more rigorous, is it recommended to delete it?
There was a problem hiding this comment.
I can't really think when this would be called, so I think it probably doesn't matter either way.
There was a problem hiding this comment.
@danielroe Got it, Normal operation here would never call. I wish I could remove this if you prefer cleaner code.
danielroe
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1512
In Mastodon, content warning (spoiler text) will be included in the character count
But not currently
After this PR, when the content warning (spoiler text) is activated, it will be included in the word count, and it will be ignored when it is closed.
dev.mp4