Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): es-419 cv translation support and separating some base strings for idiomatic context #1505

Merged
merged 11 commits into from
Feb 1, 2023

Conversation

mrcego
Copy link
Contributor

@mrcego mrcego commented Jan 28, 2023

First entries for es-419 country variant support. Will create PR as draft until some discussion.

There are some work separating entries from base locales to CV for idiomatic contextualization.

cc @patak-dev @alvarosabu for LATAM translations discussion
cc @userquin for correcting i18n idiomatic use

@stackblitz
Copy link

stackblitz bot commented Jan 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 0db9d40
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63da8b05ea07070008c2b448

@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 0db9d40
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63da8b05a04c260008b37c0d
😎 Deploy Preview https://deploy-preview-1505--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrcego mrcego changed the title feat(i18n): es-419 cv translation support feat(i18n): es-419 cv translation support and separating some base strings for idiomatic context Jan 29, 2023
@mrcego mrcego marked this pull request as ready for review January 29, 2023 23:30
@@ -22,7 +22,7 @@
],
"i18n-ally.preferredDelimiter": "_",
"i18n-ally.sortKeys": true,
"i18n-ally.sourceLanguage": "en-US",
"i18n-ally.sourceLanguage": "es-419",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add this file to gitignore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@userquin do you know what is best practice here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use VSCode, I don't add IntelliJ stuff to my GIT, I think it should be excluded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it, and I will keep it untouched until Core team decides how to proceed for this.

utils/language.ts Outdated Show resolved Hide resolved
},
"language": {
"display_language": "Idioma en pantalla",
"translations": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations entry should be included in base es file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is included, actually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on main, it is missing from es file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

included here?

locales/es-419.json Outdated Show resolved Hide resolved
@userquin
Copy link
Member

userquin commented Feb 1, 2023

@mrcego César, remember to send new entries to i18n channel 🙏

@patak-dev patak-dev merged commit b41b935 into elk-zone:main Feb 1, 2023
@mrcego mrcego deleted the feat/i18n-es-419-cv-translation branch April 15, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants