-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): es-419
cv translation support and separating some base strings for idiomatic context
#1505
feat(i18n): es-419
cv translation support and separating some base strings for idiomatic context
#1505
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
es-419
cv translation supportes-419
cv translation support and separating some base strings for idiomatic context
.vscode/settings.json
Outdated
@@ -22,7 +22,7 @@ | |||
], | |||
"i18n-ally.preferredDelimiter": "_", | |||
"i18n-ally.sortKeys": true, | |||
"i18n-ally.sourceLanguage": "en-US", | |||
"i18n-ally.sourceLanguage": "es-419", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add this file to gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@userquin do you know what is best practice here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use VSCode, I don't add IntelliJ stuff to my GIT, I think it should be excluded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted it, and I will keep it untouched until Core team decides how to proceed for this.
}, | ||
"language": { | ||
"display_language": "Idioma en pantalla", | ||
"translations": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translations
entry should be included in base es
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is included, actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on main, it is missing from es
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
included here?
@mrcego César, remember to send new entries to i18n channel 🙏 |
First entries for
es-419
country variant support.Will create PR as draft until some discussion.There are some work separating entries from base locales to CV for idiomatic contextualization.
cc @patak-dev @alvarosabu for LATAM translations discussion
cc @userquin for correcting i18n idiomatic use