Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial support for lists #1474

Merged
merged 10 commits into from
Jan 26, 2023
Merged

feat: initial support for lists #1474

merged 10 commits into from
Jan 26, 2023

Conversation

boehs
Copy link
Member

@boehs boehs commented Jan 26, 2023

@stackblitz
Copy link

stackblitz bot commented Jan 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 751f9cc
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63d2e980df881c0008076f93
😎 Deploy Preview https://deploy-preview-1474--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 751f9cc
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63d2e98084fbca0007c976b7

@boehs boehs changed the title feat: initial support for lists [DO NOT MERGE] feat: initial support for lists Jan 26, 2023
@boehs
Copy link
Member Author

boehs commented Jan 26, 2023

@patak-dev I'd call this "ready for review". I've done testing and everything seems to be working, but future pull requests will include the ability to view the users in the list, edit the list, etc

@boehs
Copy link
Member Author

boehs commented Jan 26, 2023

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think we can merge and iterate. We are probably not going to release for a few days so we could add this slowly to main.elk.zone without doing much buzz

@patak-dev
Copy link
Member

Would you resolve the conflicts @boehs? Then let's merge :)

@boehs
Copy link
Member Author

boehs commented Jan 26, 2023

oops, that merge went terribly. One second

@boehs
Copy link
Member Author

boehs commented Jan 26, 2023

should be good once checks pass

@patak-dev patak-dev merged commit 3904bc4 into elk-zone:main Jan 26, 2023
@patak-dev
Copy link
Member

Awesome, thanks! A solid first step 🙌🏼

@boehs boehs mentioned this pull request Jan 26, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants