-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bold and italic buttons to editor #1469
Conversation
victordelva
commented
Jan 26, 2023
•
edited
Loading
edited
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This looks good on big screens, but I'm afraid we are already out of space for mobile. @userquin also was working on some advanced features that would require space. And we got a request to hide the code block button. I think we should already have these two new ones and the code block behind a new format button that opens a toolbar on hover maybe? |
@patak-dev |
I used a dropdown. this is how it looks on smaller screens. |
It looks like there is a glitch in mobile, the keyboard collapses when the new button is pressed. Maybe is normal but we coupd check if that could be avoided |
I think a simple e.preventDefault fixes |
closes #1401 |