Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default user language when writing a publication #1446

Merged
merged 4 commits into from
Jan 25, 2023
Merged

fix: default user language when writing a publication #1446

merged 4 commits into from
Jan 25, 2023

Conversation

victordelva
Copy link
Contributor

@victordelva victordelva commented Jan 25, 2023 •
edited by patak-dev
Loading

fixes #1441

@stackblitz
Copy link

stackblitz bot commented Jan 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit bec74a4
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63d14c6a1993900008f1525c

@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit bec74a4
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63d14c6aecd0a00009ffe364
😎 Deploy Preview https://deploy-preview-1446--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev patak-dev changed the title ISSUE-1441 fix default user language when writing a publication in spanish fix: default user language when writing a publication in spanish Jan 25, 2023
@userquin
Copy link
Member

userquin commented Jan 25, 2023 •
edited
Loading

@victordelva can you solve it for any language, not only for spanish? split the language with - then get the first entry, we're using only language part in the picker: components/publish/PublishLanguagePicker.vue

@userquin userquin changed the title fix: default user language when writing a publication in spanish fix: default user language when writing a publication Jan 25, 2023
@userquin
Copy link
Member

userquin commented Jan 25, 2023 •
edited
Loading

@victordelva it is failing due to an internal error, you don't need to try to fix it, sometimes works...

@patak-dev patak-dev merged commit adb17d7 into elk-zone:main Jan 25, 2023
@patak-dev
Copy link
Member

Gracias Victor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When publicating, language is always English (not considering language set on settings)
3 participants
@victordelva @userquin @patak-dev