fix: #1348 Fixed the follow button movement UI #1383
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rkmdCodes
changed the title
rkmdCodes
changed the title
components/account/AccountHeader.vue
Outdated
| @@ -103,7 +103,7 @@ const isNotifiedOnPost = $computed(() => !!relationship?.notifying) | |||
| <AccountHandle :account="account" /> | |||
| </div> | |||
| </div> | |||
| <div absolute top-18 inset-ie-0 flex gap-2 items-center> | |||
| <div absolute top-18 inset-ie-0 flex gap-2 justify-center> | |||
There was a problem hiding this comment.
items-center here is correct. The issue is that the bell notification button is taller than the follow button. If the bell notification button size is reduced to match the follow button, then there will not be a pixel shift
There was a problem hiding this comment.
Thanks for the review!
I edited the commit and reverted the previous changes justify-center back to item-center
I found out that the issue is resolved by changing the padding of bell button from 0.5 rem to 0.4 rem p2 to p1.6 but I am getting type check error in CI check. I am still working on the issue.
There was a problem hiding this comment.
I think you needed to add class="p1.6" for this to work. I changed it back to p2 though and made the icon text-sm so we have more coherent padding.
Edited the padding of the bell notification button to match with follow button
|
I learned a lot and this was my first Open source project! |
|
@rkmdCodes it gets better and better! Welcome to Elk and OSS 🙌🏼 |
hi I am a new contributor and I have fixed the movement in follow button UI
Here is the Gif attached ...
