Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): support for Russian locale (Russian Federation variant) #1169

Merged
merged 17 commits into from
Jan 23, 2023

Conversation

Bytedefined
Copy link
Contributor

@Bytedefined Bytedefined commented Jan 15, 2023

Full support for Russian locale (Russian Federation variant).

Additional context

N/A


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

@stackblitz
Copy link

stackblitz bot commented Jan 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for elk-docs ready!

Name Link
🔨 Latest commit 6686c20
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63cf0a27946b430008b734c8
😎 Deploy Preview https://deploy-preview-1169--elk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe
Copy link
Member

danielroe commented Jan 15, 2023

Is there any reason you have opened and closed this PR a couple of times?

Edit: ah, maybe the semantic pr title check?

@Bytedefined
Copy link
Contributor Author

Is there any reason you have opened and closed this PR a couple of times?

Edit: ah, maybe the semantic pr title check?

Yes, that, and also made some improvements, but don't know how to edit an already-made PR...

@danielroe
Copy link
Member

Okay, no problem 😊 Don't worry, if you make any changes in your fork's branch they are automatically included in the PR.

Oh, and thanks for the PR!

@Bytedefined
Copy link
Contributor Author

Okay, no problem 😊 Don't worry, if you make any changes in your fork's branch they are automatically included in the PR.

Oh, and thanks for the PR!

Ah, okay. That's good to know.

And no problem!

@patak-dev
Copy link
Member

We'll wait until we have a review, I'm discussing with someone to check the translations. Thanks for being patient here.

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 6686c20
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63cf0a27d4d3c900085cf1e3
😎 Deploy Preview https://deploy-preview-1169--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skryukov skryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I never saw a ru-RF code before, it's always ru-RU. 🤔 I think we should change that before merging the initial support.

cc @patak-dev

@patak-dev patak-dev changed the title feat(i18n): Full support for Russian locale (Russian Federation variant) feat(i18n): support for Russian locale (Russian Federation variant) Jan 23, 2023
@patak-dev patak-dev merged commit f1a3c88 into elk-zone:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants