refactor animation prop into a ref method#8
Merged
elizabetdev merged 1 commit intoelizabetdev:notification_header_buttonfrom Feb 1, 2021
Conversation
chandlerprall
commented
Jan 29, 2021
| ref, | ||
| () => { | ||
| if (buttonRef) { | ||
| (buttonRef as any).triggerAnimation = () => { |
Author
There was a problem hiding this comment.
This part that breaks good practices, but seems to be a decent compromise.
chandlerprall
commented
Jan 29, 2021
| () => { | ||
| if (buttonRef) { | ||
| (buttonRef as any).triggerAnimation = () => { | ||
| const keyframes: Keyframe[] = [ |
Author
There was a problem hiding this comment.
This is converted straight from the CSS animation. We can probably find a small math solution to generating these in a loop instead. Either way is fine.
chandlerprall
commented
Jan 29, 2021
| 'euiHeaderSectionItemButton__content--isAnimating': animation, | ||
| }); | ||
| const animationClasses = classNames([ | ||
| 'euiHeaderSectionItemButton__content', |
Author
There was a problem hiding this comment.
This PR did not update all snapshots affected by this change.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
animationprop into ananimatemethod on the ref