Skip to content

Re-enable the notification header button animation test #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elizabetdev merged 1 commit into from
Feb 10, 2021
Merged

Re-enable the notification header button animation test #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions src/components/header/header_section/header_section_item_button.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@
*/

import React from 'react';
import { render, shallow } from 'enzyme';
import { mount, render, shallow } from 'enzyme';
import { requiredProps } from '../../../test/required_props';

import { EuiHeaderSectionItemButton } from './header_section_item_button';
import {
EuiHeaderSectionItemButton,
EuiHeaderSectionItemButtonRef,
} from './header_section_item_button';

describe('EuiHeaderSectionItemButton', () => {
test('is rendered', () => {
Expand Down Expand Up @@ -67,13 +70,31 @@ describe('EuiHeaderSectionItemButton', () => {
});
});

// test('renders animation', () => {
// const component = render(
// <EuiHeaderSectionItemButton animation={true} notification={true} />
// );
//
// expect(component).toMatchSnapshot();
// });
describe('animation', () => {
const animate = HTMLElement.prototype.animate;
beforeAll(() => {
HTMLElement.prototype.animate = jest.fn();
});
afterAll(() => {
HTMLElement.prototype.animate = animate;
});

it('renders animation', () => {
expect.assertions(2);

mount(
<EuiHeaderSectionItemButton ref={testAnimation} notification={true} />
);

function testAnimation(element: EuiHeaderSectionItemButtonRef) {
if (element) {
expect(element.animate).toHaveBeenCalledTimes(0);
element.triggerAnimation();
expect(element.animate).toHaveBeenCalledTimes(1);
}
}
});
});

describe('onClick', () => {
test("isn't called upon instantiation", () => {
Expand Down
8 changes: 5 additions & 3 deletions src/components/header/header_section/header_section_item_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ export type EuiHeaderSectionItemButtonProps = CommonProps &
notificationColor?: EuiNotificationBadgeProps['color'];
};

export type EuiHeaderSectionItemButtonRef = HTMLButtonElement | null;
export type EuiHeaderSectionItemButtonRef =
| (HTMLButtonElement & { triggerAnimation: () => void })
| null;

export const EuiHeaderSectionItemButton = forwardRef<
EuiHeaderSectionItemButtonRef,
Expand All @@ -67,7 +69,7 @@ export const EuiHeaderSectionItemButton = forwardRef<
*/
ref
) => {
const [buttonRef, setButtonRef] = useState<EuiHeaderSectionItemButtonRef>();
const [buttonRef, setButtonRef] = useState<HTMLButtonElement | null>();
const animationTargetRef = useRef<HTMLSpanElement | null>(null);

useImperativeHandle<
Expand Down Expand Up @@ -192,7 +194,7 @@ export const EuiHeaderSectionItemButton = forwardRef<
duration: 5000,
});
};
return buttonRef;
return buttonRef as EuiHeaderSectionItemButtonRef;
} else {
return null;
}
Expand Down