Externalize Vendor Code #3393
Draft
Externalize Vendor Code #3393
+42,295
−121,281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| file: fs.createReadStream(audioFile.path), | ||
| model: "whisper-1", | ||
| }); | ||
| const transcription = await runtime.useModel(ModelClass.TRANSCRIPTION, fs.createReadStream(audioFile.path)); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 5 hours ago
To fix the problem, we need to ensure that the file path derived from user input is validated and sanitized before being used. We can achieve this by resolving the file path to a known safe directory and ensuring it does not escape this directory. This can be done using path.resolve and fs.realpathSync to normalize the path and check it against the safe directory.
- Define a safe root directory where uploaded files are stored.
- Resolve the
audioFile.pathto ensure it is within the safe directory. - If the resolved path is not within the safe directory, return an error response.
Suggested changeset
1
packages/agent/src/server.ts
| @@ -93,3 +93,9 @@ | ||
|
|
||
| const transcription = await runtime.useModel(ModelClass.TRANSCRIPTION, fs.createReadStream(audioFile.path)); | ||
| const safeRoot = path.join(process.cwd(), "/data/uploads"); | ||
| const resolvedPath = fs.realpathSync(path.resolve(safeRoot, audioFile.path)); | ||
| if (!resolvedPath.startsWith(safeRoot)) { | ||
| res.status(403).send("Invalid file path"); | ||
| return; | ||
| } | ||
| const transcription = await runtime.useModel(ModelClass.TRANSCRIPTION, fs.createReadStream(resolvedPath)); | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
* added character methods * missing comma/syntax issue
fix: add @solana/web3.js deps
* clean up types and registry validation * dont check in lock files
* db path resolution * Update resolve-database-path.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has many core breaking changes
The main change is that vendor code has been removed from core. For any third party vendor plugins, interfaces are available to register plugins to handle nearly everything (or at least there will be soon)
Other than that, many things were moved, removed, consolidated or simplified. The primary goal of this branch is to enable the project to scale and reach more users. Also, switched from
pnpmtobun