fix(ui): keep default cloud onboarding steward-only - #15532
Merged
Merged
Conversation
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
lalalune
pushed a commit
that referenced
this pull request
Jul 23, 2026
Three journey-harness gaps, no product changes: - Seed eliza:enable-runtime-chooser=1 — steps 01-03 walk the Local/Cloud runtime chooser, which is off by default since cloud-only onboarding (#15244/#15532); same opt-in first-run-startup.spec.ts already uses. - Seed eliza:permissions-primed=1 — the injected __electrobunWindowId makes the platform read as desktop, arming the post-onboarding permission-priming modal (#12331) whose overlay swallowed every mid-journey click (7 step timeouts per viewport plus downstream mobile chaos). - Mock-lane stubs for GET /api/models*, GET /api/accounts, and POST /api/turns/*/abort — the keyless stub 501s them, tripping the diagnostics gate once the earlier steps proceed. Verified: both journeys (desktop + mobile) pass locally in 59.8s total (previously 9 and 11 failed steps at 11-14 minutes each in CI). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pair/pairbehavior for explicit callers that do not request the Steward adapterVerification
bun run --cwd packages/ui test src/first-run/first-run-runtime-flag.test.ts src/api/client-cloud-select-or-provision.test.ts src/first-run/first-run-finish.force-fresh.test.tsbunx @biomejs/biome check packages/ui/src/first-run/first-run-runtime-flag.ts packages/ui/src/first-run/first-run-runtime-flag.test.ts packages/ui/src/api/client-cloud.ts packages/ui/src/api/client-cloud-select-or-provision.test.ts packages/ui/src/first-run/first-run-finish.ts packages/ui/src/first-run/first-run-finish.force-fresh.test.tsgit diff --checkbun run --cwd packages/app audit:apppartially passed: Playwright visual audit passed 241/241 with broken=0 and undebted-needs-work=0; OCR triage failed on an unrelatedbuiltin-browsermobile-portrait baseline/content drift (Enter a URL | Open a website | Summarize a page | Search the webmissing). This branch does not touch Browser view code.Fixes #15527