Skip to content

test(agent-skills): stub resolveStateDir in core mock - #13289

Merged
lalalune merged 1 commit into
developfrom
fix/13270-agent-skills-core-mock-clean
Jul 4, 2026
Merged

lalalune merged 1 commit into
developfrom
fix/13270-agent-skills-core-mock-clean

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

What

Follow-up to #13270: the newly merged skill-discovery-helpers.test.ts imports code paths that reach packages/skills, which now expects @elizaos/core.resolveStateDir. The plugin-agent-skills Vitest setup hand-mocks @elizaos/core, so the focused test failed during import with:

No "resolveStateDir" export is defined on the "@elizaos/core" mock

This adds a deterministic resolveStateDir stub to the package test mock.

Validation

bun run --cwd plugins/plugin-agent-skills test src/api/skill-discovery-helpers.test.ts
Test Files  1 passed (1)
Tests       7 passed (7)

bunx @biomejs/biome check plugins/plugin-agent-skills/src/__tests__/core-test-mock.ts
Checked 1 file in 16ms. No fixes applied.

Evidence N/A: test-harness-only fix; no runtime/UI behavior.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 59f339a7-c258-48b9-914b-0e489567c24d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/13270-agent-skills-core-mock-clean

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune
lalalune merged commit c1c22fc into develop Jul 4, 2026
19 of 37 checks passed
@lalalune
lalalune deleted the fix/13270-agent-skills-core-mock-clean branch July 4, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants