fix(#12265): annotate the last agent empty catches per error-policy rubric - #12921
Merged
Merged
Conversation
Fallback-slop sweep (packages/agent, #12182): the 3 remaining unannotated empty catches in the agent API layer are justified handlers, now carrying grep-able `// error-policy:J<N>` annotations per the binding rubric: - server.ts WS-upgrade `socket.destroy()` → J6 best-effort teardown (the socket may already be destroyed after a failed upgrade). - wallet-capability.ts EVM service-registry probes (×2) → J3: a service lookup that throws means that provider isn't usable here, so it is treated as absent and the next candidate is tried. The function returns an honest `false` (capability absent), never a fabricated success. No behavior change — comments added inside the catch blocks only. Clears the last empty-catch sites in packages/agent/src so `noEmptyBlockStatements` holds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 4, 2026
lalalune
pushed a commit
that referenced
this pull request
Jul 4, 2026
…/fabricated-default/promise-swallow to fail-fast Deep re-sweep of the remaining fallback-slop in packages/agent after the headline files were handled by #12766 / #12921. Empty-catch count in this slice is already 0; this pass targets the log-and-return-empty catches that make a broken pipeline read as a legitimately-empty result, plus fail-closed swallows. Converted (behavior-changing, fail-fast; each with a real error-path test): - providers/recent-conversations.ts + relevant-conversations.ts: on a recall failure both providers returned the IDENTICAL empty context as a legit-empty recall (the banned "not loaded reads as empty" conflation). Now runtime.reportError surfaces the broken pipeline via RECENT_ERRORS while the provider still degrades to empty (annotated error-policy:J4). Removed the now-unused logger imports (logger-only rule still holds; reportError logs). - security/access.ts hasPrivateAccess: a throw from the core private-access check was silently swallowed to `return false` — fail-closed is correct, but a broken role/world-resolution pipeline would deny forever with no signal. Now reports via runtime.reportError and stays fail-closed (error-policy:J4). Annotated (evaluated, kept — not slop): - api/views-registry.ts ×2 indexView `.catch(() => {})`: indexView self-degrades (its own catch logs and falls back to keyword search); the call-site catch only suppresses a stray pre-embed rejection so a background task cannot crash the loop (error-policy:J5). Deferred (ambiguous absence-vs-failure, per this wave's scope): bare `return null/[]/false` catches and `?? <lit>` defaults where legitimate-absence cannot be cleanly distinguished from masking-a-failure. Tests: 6 new fast-fail assertions across 3 files (recent-conversations, relevant-conversations.faildast, access) — all green; each asserts reportError fires on the real failure AND that a legit-absence path does NOT report. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the fallback-slop sweep for
packages/agent(#12265, parent #12182). The 3 remaining unannotated empty catches in the agent API layer are justified handlers; this adds the grep-able// error-policy:J<N>annotations the binding rubric requires, with no behavior change (comments added inside the catch blocks only).api/server.ts— the WS-upgradesocket.destroy()cleanup → J6 best-effort teardown (the socket may already be destroyed after a failed upgrade).api/wallet-capability.ts— the two EVM service-registry probes → J3: a service lookup that throws means that provider isn't usable here, so it is treated as absent and the next candidate is tried. The function returns an honestfalse(capability absent), never a fabricated success.This clears the last truly-empty catch sites in
packages/agent/src(3 → 0), sonoEmptyBlockStatementsholds for them.Validation
node packages/scripts/error-policy-ratchet.mjs→no new fallback-slop in touched files(the enforced diff-scoped gate).bunx @biomejs/biome checkon both touched files → clean, no fixes.packages/agent/src: 3 on develop → 0 on this branch.git grep 'error-policy:J[36]'.Evidence rows
🤖 Generated with Claude Code