Skip to content

docs(#12844): add cloud routing tail headers - #12912

Merged
lalalune merged 1 commit into
developfrom
docs/comments-b07d-cloud-routing-infra
Jul 4, 2026
Merged

docs(#12844): add cloud routing tail headers#12912
lalalune merged 1 commit into
developfrom
docs/comments-b07d-cloud-routing-infra

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • add required prose headers to the five packages/cloud/routing/src TypeScript source files called out by the B07-D tail audit
  • convert the docs redirect Worker's line-comment opener to the required top /** ... */ prose header
  • add the missing deterministic harness header to the docs redirect Worker test

Refs #12844.

Verification

  • PASS: bun run check:comment-only (7 source file(s) changed; every code token identical to origin/develop)
  • PASS: bunx @biomejs/biome check packages/cloud/routing/src/features.ts packages/cloud/routing/src/index.ts packages/cloud/routing/src/resolve.test.ts packages/cloud/routing/src/resolve.ts packages/cloud/routing/src/types.ts packages/cloud/docs-redirect/src/worker.test.ts packages/cloud/docs-redirect/src/worker.ts
  • PASS: bun run --cwd packages/cloud/routing test (1 file / 61 tests)
  • PASS: bun run --cwd packages/cloud/docs-redirect test (1 file / 6 tests)
  • PASS: git diff --check origin/develop...HEAD

Verify limitation

  • bun run verify was attempted twice during the surrounding comment-only sweep and failed outside this change at @elizaos/cloud-shared:typecheck: missing declarations for drizzle-orm* resolved through dist/node_modules, followed by implicit-any errors in plugins/plugin-sql/src/schema/*. This branch is comment-only and the scoped verifier proves zero functional token changes.

Evidence

  • N/A - trajectories/screenshots/video/audio/domain artifacts: comments-only change, zero functional diff machine-checked by scripts/assert-comment-only-diff.mjs.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5db1e2f7-167c-4aaa-88c9-39555c463604

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/comments-b07d-cloud-routing-infra

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Local validation pass from an isolated checkout at /tmp/eliza-pr-12912.

Commands run:

git remote set-url origin https://github.com/elizaOS/eliza.git
git fetch origin develop
bun run check:comment-only
bunx @biomejs/biome check packages/cloud/routing/src/features.ts packages/cloud/routing/src/index.ts packages/cloud/routing/src/resolve.test.ts packages/cloud/routing/src/resolve.ts packages/cloud/routing/src/types.ts packages/cloud/docs-redirect/src/worker.test.ts packages/cloud/docs-redirect/src/worker.ts
bun run --cwd packages/cloud/routing test
bun run --cwd packages/cloud/docs-redirect test
git diff --check origin/develop..HEAD

Result: all passed. check:comment-only reported 7 source files changed with code tokens identical to origin/develop; routing tests passed 61 tests and docs-redirect tests passed 6 tests.

@lalalune
lalalune merged commit 3b6911e into develop Jul 4, 2026
18 of 39 checks passed
@lalalune
lalalune deleted the docs/comments-b07d-cloud-routing-infra branch July 4, 2026 05:03
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

❌ PR title does not match the required pattern. Please use one of these formats:

  • 'type: description' (e.g., 'feat: add new feature')
  • 'type(scope): description' (e.g., 'chore(core): update dependencies')
    Valid types: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert, release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants