Skip to content

docs(#12231): prose headers + churn cleanup — core root + types load-bearing modules (B01 part 2) - #12874

Merged
lalalune merged 1 commit into
developfrom
chore/12231-core-part2
Jul 4, 2026
Merged

lalalune merged 1 commit into
developfrom
chore/12231-core-part2

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

What

Batch B01 part 2 of the repo-wide comment cleanup (#12231, parent #12181) — the
load-bearing files at packages/core/src root + types/. Every in-scope file gets an
accurate purpose-explaining prose header; churn comments are removed/rewritten to present-tense
durable fact.

Comments only — zero functional diff. Machine-proven by node scripts/assert-comment-only-diff.mjs:
every changed file's TypeScript code-token stream is byte-identical to base.

Scope (58 files)

The framework's highest-dividend modules: runtime.ts (the 10k-line AgentRuntime, headered with
its getSetting/embedding-width invariants), plugin lifecycle, entities/character, roles/access,
memory/db/search, cloud auth+routing, action naming/docs, settings/boot, connectors/services,
utils, and the core type barrels (types/).

Follows #12824 (B01 part 1, core boundary/data/schema subsystems — merged). Remaining B01:
features/, services/, utils/ in follow-up per-subtree PRs.

Verification

node scripts/assert-comment-only-diff.mjs
# OK — 58 source file(s) changed; every code token identical to base. Comments only.

Part of #12231.

…bearing modules (B01 part 2)

Adds accurate prose file headers and removes/rewrites churn comments across 58
load-bearing files at packages/core/src root + types/: the AgentRuntime
(runtime.ts, with its getSetting/embedding-width invariants), plugin lifecycle,
entities/character, roles/access, memory/db/search, cloud auth+routing, action
naming/docs, settings/boot, connectors/services, utils, and the core type
barrels.

Comments only — zero functional diff, machine-proven by
scripts/assert-comment-only-diff.mjs (every TypeScript code token identical to base).

Part of #12231 (parent #12181). Follows #12824 (B01 part 1).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f730c41-5ca9-4773-a252-75472dffea0f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/12231-core-part2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Machine-verified comment-only: node scripts/assert-comment-only-diff.mjsOK — 58 source file(s) changed; every code token identical to base. Comments only. runtime.ts (the 10k-line AgentRuntime) gets a real 2-3 paragraph header capturing what it owns + its load-bearing invariants (getSetting() deliberately never reading process.env for multi-tenant secret isolation; embedding-width pinning per #8769). Queuing auto-merge on green.

@lalalune
lalalune merged commit cf63854 into develop Jul 4, 2026
10 of 62 checks passed
@lalalune
lalalune deleted the chore/12231-core-part2 branch July 4, 2026 04:53
lalalune added a commit that referenced this pull request Jul 4, 2026
…s (B01 part 3) (#12926)

Adds accurate prose file headers and removes/rewrites churn comments across 225
files in packages/core/src/features — the core capability subsystems:
advanced-capabilities, basic-capabilities, trust, documents, messaging,
plugin-manager, secrets, advanced-memory, working-memory, trajectories,
advanced-planning, plugin-config, sub-agent-credentials, oauth, credential-proxy,
payments, subscription-auth, autonomy. Each file's header names the capability it
belongs to and its role (action / provider / service / schema).

Comments only — zero functional diff, machine-proven by
scripts/assert-comment-only-diff.mjs (every TypeScript code token identical to base).

Part of #12231 (parent #12181). Follows #12824 (p1) and #12874 (p2).

Co-authored-by: moon <stupidlybadadvice@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
lalalune added a commit that referenced this pull request Jul 4, 2026
…B01 part 4, final) (#13030)

Adds accurate prose file headers and removes/rewrites churn comments across 77
files in packages/core/src/services (long-lived runtime singletons) and
packages/core/src/utils (shared helpers). Completes the packages/core header
sweep for B01.

Comments only — zero functional diff, machine-proven by
scripts/assert-comment-only-diff.mjs (every TypeScript code token identical to base).

Part of #12231 (parent #12181). Follows #12824 (p1), #12874 (p2), #12926 (p3).

Co-authored-by: moon <stupidlybadadvice@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
lalalune added a commit that referenced this pull request Jul 4, 2026
…+ __tests__ + residual (B01 part 5, complete) (#13039)

Adds accurate prose file headers and removes/rewrites churn comments across the
final headerless packages/core files: the runtime/ agent-loop internals (planner
loop, action catalog/tiering/gating, context registry/renderer, message handler,
evaluators) and their __tests__, the top-level packages/core/src/__tests__ suite,
and scattered stragglers (search.ts license-block-preserving header, secret-swap
bench/fuzz/redteam, feature test files). This completes the packages/core header
sweep for B01 — every in-scope source file now carries a purpose-explaining header.

Comments only — zero functional diff, machine-proven by
scripts/assert-comment-only-diff.mjs (every TypeScript code token identical to base).

Part of #12231 (parent #12181). Completes B01 across #12824 (p1), #12874 (p2),
#12926 (p3), #13030 (p4), and this PR.

Co-authored-by: moon <stupidlybadadvice@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
lalalune added a commit that referenced this pull request Jul 4, 2026
…er + registry (B01 complete) (#13045)

Adds top-of-file prose headers to the ~45 files skipped by prior automated B01
passes (bare test files and modules that carried export-level JSDoc but no
file-level header): packages/core stragglers (character-utils.test, room action,
recall-embed, feature test files, __tests__ residual), packages/logger/src/logger.ts,
and packages/registry/src/first-party/*. With this, every in-scope source file in
the B01 batch (packages/core + prompts/logger/registry/skills) carries a
purpose-explaining header.

Comments only — zero functional diff, machine-proven by
scripts/assert-comment-only-diff.mjs (every TypeScript code token identical to base).

Closes #12231 (parent #12181). Final part after #12824/#12874/#12926/#13030/#13039.

Co-authored-by: moon <stupidlybadadvice@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant