fix(ui): hide wallet launcher subpages by group - #12521
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Review follow-up pushed in Hyperliquid/Polymarket Fix included here:
Local verification:
|
…et" (#12915) PR #12521 replaced the launcher's hyperliquid/polymarket id blocklist with the group-based wallet sub-page hide (isGroupedLauncherSubPage keys on group === "wallet"). The real plugin-hyperliquid registration carries group: "wallet" (plugins/plugin-hyperliquid/src/plugin.ts), but the home-screen e2e views stub still registered hyperliquid without the group, so curation no longer dropped it and the 'hyperliquid is absent from the launcher' assertion failed on the develop tip. Mirror the real registration in the stub so the e2e exercises the actual group-based hide instead of the removed blocklist. Product behavior was already correct; this is fixture drift only.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Summary
groupmetadata into the view catalog and launcher entries.packages/ui; wallet subpages now stay out of the launcher by declaringgroup: "wallet".WalletSectionNav.tsx.Closes part of #12089 item 30.
Verification
bun run --cwd packages/ui test -- src/components/pages/WalletSectionNav.test.tsx src/navigation/index.test.ts src/components/pages/launcher-curation.test.tsbunx @biomejs/biome check packages/ui/src/components/pages/WalletSectionNav.tsx packages/ui/src/components/pages/launcher-curation.ts packages/ui/src/components/pages/launcher-curation.test.ts packages/ui/src/hooks/useAvailableViews.ts packages/ui/src/hooks/view-catalog.ts packages/ui/src/navigation/index.ts packages/ui/src/navigation/index.test.tsbun run --cwd packages/ui typecheckfails insrc/testing/e2e-runner/fixture-bundle.ts:143with TS2321/TS2769 around Vite pluginAcceptedPlugintyping.Evidence / N/A
packages/app audit:appremains required before declaring the UI change fully done.