Skip to content

fix(ui): hide wallet launcher subpages by group - #12521

Merged
lalalune merged 2 commits into
developfrom
fix/12089-wallet-section-registry-current
Jul 4, 2026
Merged

lalalune merged 2 commits into
developfrom
fix/12089-wallet-section-registry-current

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Carries app-shell page group metadata into the view catalog and launcher entries.
  • Removes hardcoded Hyperliquid/Polymarket launcher hiding from packages/ui; wallet subpages now stay out of the launcher by declaring group: "wallet".
  • Restores the required prose header on WalletSectionNav.tsx.

Closes part of #12089 item 30.

Verification

  • PASS: bun run --cwd packages/ui test -- src/components/pages/WalletSectionNav.test.tsx src/navigation/index.test.ts src/components/pages/launcher-curation.test.ts
  • PASS: bunx @biomejs/biome check packages/ui/src/components/pages/WalletSectionNav.tsx packages/ui/src/components/pages/launcher-curation.ts packages/ui/src/components/pages/launcher-curation.test.ts packages/ui/src/hooks/useAvailableViews.ts packages/ui/src/hooks/view-catalog.ts packages/ui/src/navigation/index.ts packages/ui/src/navigation/index.test.ts
  • FAIL (unrelated current-develop type issue): bun run --cwd packages/ui typecheck fails in src/testing/e2e-runner/fixture-bundle.ts:143 with TS2321/TS2769 around Vite plugin AcceptedPlugin typing.

Evidence / N/A

  • App visual audit: not run in this pass; this is a small launcher curation/data-flow fix, but full packages/app audit:app remains required before declaring the UI change fully done.
  • Real-LLM trajectories: N/A - no agent/action/prompt/model behavior changed.
  • Backend logs/domain artifacts/on-chain evidence: N/A - no server, chain, or data mutation path changed.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea9698ac-2570-4000-9130-a53eb86304ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/12089-wallet-section-registry-current

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Review follow-up pushed in 32b8f3b564: the first pass carried app-shell group metadata into launcher entries, but live web/desktop also receives network /api/views entries, and those entries win over app-shell fallback entries in useAvailableViews.

Hyperliquid/Polymarket ViewDeclarations did not declare group: "wallet", so the launcher filter could still leak them when the backend view registry was live.

Fix included here:

  • add ViewDeclaration.group
  • set group: "wallet" on Hyperliquid and Polymarket view declarations
  • add an agent registry test proving listViews() preserves the group for client launcher curation

Local verification:

  • bunx @biomejs/biome check ... passed on all touched files
  • focused Vitest runs could not complete in a fresh review worktree because dependency/artifact setup was incomplete after an interrupted bun install: UI failed resolving @elizaos/cloud-routing / bidi-js, and agent failed on missing generated i18n data. No assertion failure was reached; CI on the pushed branch is the clean verifier.

@lalalune
lalalune merged commit 64fd033 into develop Jul 4, 2026
36 of 72 checks passed
@lalalune
lalalune deleted the fix/12089-wallet-section-registry-current branch July 4, 2026 02:47
lalalune pushed a commit that referenced this pull request Jul 4, 2026
…et" (#12915)

PR #12521 replaced the launcher's hyperliquid/polymarket id blocklist with
the group-based wallet sub-page hide (isGroupedLauncherSubPage keys on
group === "wallet"). The real plugin-hyperliquid registration carries
group: "wallet" (plugins/plugin-hyperliquid/src/plugin.ts), but the
home-screen e2e views stub still registered hyperliquid without the group,
so curation no longer dropped it and the 'hyperliquid is absent from the
launcher' assertion failed on the develop tip.

Mirror the real registration in the stub so the e2e exercises the actual
group-based hide instead of the removed blocklist. Product behavior was
already correct; this is fixture drift only.
@claude

claude Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants