test(#10722): add plugin-views keyboard focus-order audit to the WebKit ui-smoke lane

[lalalune]

What

Expands the existing opt-in WebKit ui-smoke project (PLAYWRIGHT_WEBKIT=1) to include plugin-views-visual.spec.ts — the Tab-order / sequential-focus-navigation audit — alongside the chat pointer/focus/composer specs it already runs.

Why WebKit specifically: the registered plugin views ship in the iOS/macOS WKWebView, so a WebKit focus or sequential-focus-navigation divergence must be caught on the engine that actually ships to iOS — not only on Chromium. CDP-touch specs (Input.dispatchTouchEvent is Chromium-only) intentionally stay on Chromium; clipboard/mic specs remain excluded (WebKit doesn't grant those permissions).

Config-only change; keeps the PLAYWRIGHT_WEBKIT=1 opt-in gating so the default lane never reddens where the WebKit browser isn't installed.

⚠️ Status: pushed for review, NOT yet merged

Biome clean, rebased clean onto develop, and the WebKit browser (webkit-2311) is present. But the ui-smoke webServer did not boot in this session (unrelated dev-server startup issue under load), so I could not confirm plugin-views-visual runs green on WebKit here. Before merge it needs one clean PLAYWRIGHT_WEBKIT=1 run — either it passes (merge) or it surfaces a real WebKit focus divergence (a genuine #10722 finding to fix). Do not merge until run green on WebKit. Refs #10722.

🤖 Generated with Claude Code

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c3a9b4f-e118-4b3c-ab1d-98ce94e354e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/10722-webkit-ui-smoke

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[lalalune]

Validation attempted on rebased branch against origin/develop.

Command:
PLAYWRIGHT_WEBKIT=1 node packages/app/scripts/run-ui-playwright.mjs --config playwright.ui-smoke.config.ts --project=webkit test/ui-smoke/plugin-views-visual.spec.ts

Result: blocked before app assertions. The app/view build and Playwright startup completed, but all 55 WebKit cases failed at browser launch because this host is missing libnice.so.10:

Host system is missing dependencies to run browsers. Missing libraries: libnice.so.10

Passwordless sudo is not available on this machine, so I could not install the missing WebKit dependency here. Leaving unmerged per the PR body requirement: do not merge until a real WebKit run is green.

[lalalune]

Validation update: I ran the requested opt-in WebKit smoke locally from a clean temp worktree at commit 2f7cb59c8f.

Command:
PLAYWRIGHT_WEBKIT=1 node scripts/run-ui-playwright.mjs --config playwright.ui-smoke.config.ts test/ui-smoke/plugin-views-visual.spec.ts --project=webkit

Result: not merge-ready. The suite built the plugin views/core packages and reached Playwright, but all 55 plugin-views-visual WebKit cases failed before page load because this host is missing a WebKit runtime dependency:

browserType.launch: Host system is missing dependencies to run browsers. Missing libraries: libnice.so.10

I also checked whether I could install it here; noninteractive sudo is unavailable (sudo -n true requires a password), so I cannot produce the required green WebKit run from this environment. Keeping this PR open is the right call until it passes on a WebKit-capable runner or dev host.

[lalalune]

HOLD — config is coherent; the lane has never run. Verified: the regex feeds only the opt-in webkit project, serviceWorkers:"block" protects the spec's page.route fixtures, plugin-views-visual.spec.ts has no CDP/clipboard blockers, and the default lane can't redden. But per your own PR body — "Do not merge until run green on WebKit" — the expanded lane has literally never executed (webServer never booted in your session). To merge: one clean PLAYWRIGHT_WEBKIT=1 bunx playwright test --config playwright.ui-smoke.config.ts --project=webkit run in packages/app; if it reds, that's a genuine #10722 finding to fix first. Nit: chromium+webkit write screenshots/audit JSONs to the same test-results/plugin-views/ paths — suffix by browserName to stop the silent overwrite.

[lalalune]

Update — config is correct; WebKit is env-blocked on this host (precise blocker)

Got past the earlier "webServer won't boot" (that was a port-31337 collision with an adb-forward, now cleared). The WebKit browser itself won't launch on this host:

browserType.launch: Host system is missing dependencies to run browsers.
  Missing libraries:  libnice.so.10

libnice.so.10 is absent system-wide and npx playwright install-deps webkit requires sudo (no non-interactive path here), so I can't provision it. The webkit-2311 browser binary is present; only the OS-level dep is missing.

So the config change is verified sound (biome clean, rebased clean, correctly scoped — CDP-touch specs stay Chromium, clipboard/mic specs excluded), but the actual plugin-views-visual WebKit run needs an environment with WebKit's system deps installed (playwright install-deps webkit on a CI runner or dev box with sudo). On such a host this either passes or surfaces a real WebKit focus/sequential-nav divergence — a genuine #10722 finding. Ready to merge once run green on a WebKit-capable host. Refs #10722.

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[lalalune]

Rebased onto current origin/develop (3b51a0be36) and force-pushed 428546d23e.

Local validation in /tmp/eliza-11877-pr:

• git diff --check origin/develop...HEAD ✅
• bunx @biomejs/biome check packages/app/playwright.ui-smoke.config.ts ✅
• PLAYWRIGHT_WEBKIT=1 node scripts/run-ui-playwright.mjs --config playwright.ui-smoke.config.ts --project=webkit test/ui-smoke/plugin-views-visual.spec.ts ❌ blocked before assertions: WebKit cannot launch on this host because the OS is missing libnice.so.10.

The WebKit command built the plugin view bundles and shared/core prerequisites, then all 57 rows failed immediately at browserType.launch with:

Host system is missing dependencies to run browsers.
Missing libraries:
    libnice.so.10

So this still should not merge until CI or another host with WebKit system deps installed produces one green PLAYWRIGHT_WEBKIT=1 run.

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[lalalune]

Rebased again onto current origin/develop (8dcfe07e91) and force-pushed 2998447bc8 after #11904 landed.

Validation after this rebase:

• git diff --check origin/develop...HEAD ✅
• bunx @biomejs/biome check packages/app/playwright.ui-smoke.config.ts ✅

The WebKit runtime blocker from the previous local run remains environmental on this host (libnice.so.10 missing), so this PR still needs one green PLAYWRIGHT_WEBKIT=1 run on CI/a host with WebKit system deps before merge.

[github-actions]

❌ PR title does not match the required pattern. Please use one of these formats:

• 'type: description' (e.g., 'feat: add new feature')
• 'type(scope): description' (e.g., 'chore(core): update dependencies')
  Valid types: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert, release

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.