Skip to content

fix(ui): stop first-row home widgets overlapping on mobile (#11752) - #11866

Merged
lalalune merged 1 commit into
developfrom
fix/11752-widget-overlap
Jul 3, 2026
Merged

fix(ui): stop first-row home widgets overlapping on mobile (#11752)#11866
lalalune merged 1 commit into
developfrom
fix/11752-widget-overlap

Conversation

@lalalune

@lalalune lalalune commented Jul 3, 2026

Copy link
Copy Markdown
Member

Root cause

Home-slot widgets rendered a bare HomeWidgetCard (a flex w-full button) with no grid-span wrapper. As direct children of the 4-column home grid, each fell back to a single auto-placed 1-column track — so two widgets could be auto-placed into overlapping areas, producing the reported first-row collision ("Overdr[icon]wn$.." — finances "Overdrawn" colliding with the goals icon/value).

Fix

Every home widget now wraps its card in <div className="min-w-0 {spanClassName}">, so the widget's root grid item carries the host-provided col-span and each widget occupies a distinct, non-overlapping grid area. Added a spanClassName field to the widget type (mirrors WidgetProps.spanClassName), applied on the home slot only, absent elsewhere. Touches the 8 home widgets (agent-orchestrator, finances-alerts, goals-attention, health-sleep, inbox-unread, needs-attention, notifications, todo) + types.ts + home-widget-card.tsx.

Not a z-index band-aid — the grid items now genuinely span correctly.

Verification

  • New test packages/ui/src/widgets/WidgetHost.home-span.test.tsx (4/4): asserts each home widget's root element carries the host col-span so two 2-col widgets share one 4-col row as distinct areas (a bare card with no span wrapper is the failing case it guards).
  • Broader widget/home suite: 185/185 across 30 files.
  • Regenerated home-screen e2e screenshots (__e2e__/output-home/*.png) — row 1 no longer overlaps.
  • biome clean, typecheck clean.

Evidence: .github/issue-evidence/11752-widget-overlap/. Closes #11752.

🤖 Generated with Claude Code

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7b6abf78-f861-495c-85e4-83ca1fa9d743

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/11752-widget-overlap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

… salvaged from rate-limited lane

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lalalune
lalalune force-pushed the fix/11752-widget-overlap branch from 42cbf0e to ae2ccfb Compare July 3, 2026 10:11
@lalalune
lalalune merged commit be7c734 into develop Jul 3, 2026
1 check passed
@lalalune
lalalune deleted the fix/11752-widget-overlap branch July 3, 2026 10:11

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home widget grid: first-row widgets overlap (icon/text collision) on mobile

2 participants