test(cloud): mock ad accounts as active in credit-reconciliation suite — un-red develop after #11619 gate

[lalalune]

What

#11619 gated updateCampaign on account.status === "active" (closing the suspended-account spend leg from #11364) but did not update the mocks in packages/cloud/shared/src/lib/services/__tests__/ad-campaign-credit-reconciliation.test.ts, which stub adAccountsRepository.findById without a status field.

Since that merge, 7 of the suite's 13 tests fail on develop with:

error: Ad account is not active (status: undefined); it must be approved before running campaigns
      at updateCampaign (packages/cloud/shared/src/lib/services/advertising/index.ts:696)

— the gate throws before the credit-hold reconciliation logic under test is ever reached.

Fix

Add status: "active" to the two beforeEach account mocks so the suite exercises budget-change hold reconciliation again. The approval gate itself remains covered by ad-account-approval.test.ts (15 tests, unchanged).

Evidence

On origin/develop @ 80ba667fd0 (pre-fix):

bun test packages/cloud/shared/src/lib/services/__tests__/ad-campaign-credit-reconciliation.test.ts
 6 pass
 7 fail   # all: 'Ad account is not active (status: undefined)'

With this fix (same base):

bun test .../ad-campaign-credit-reconciliation.test.ts .../ad-account-approval.test.ts .../ad-inventory.test.ts .../ad-tag-token.test.ts
 48 pass
 0 fail

Frontend/video/screenshot/trajectory evidence: N/A — test-only change to existing unit-test mocks; no runtime surface.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e81352d9-e0c7-462e-a29f-53f46b3ef980

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ad-reconciliation-gate-mocks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[lalalune]

Validation after rebase onto current origin/develop:

• Confirmed the diff is only the two missing status: "active" fields in adAccountsRepository.findById mocks for the reconciliation suite.
• Initial raw bun test ... run reached the expected passing test output but ended with Bun WriteFailed while dumping the huge coverage table, so I reran with the compact reporter.

Checks run:

• bun test --coverage-reporter=lcov --reporter=dots packages/cloud/shared/src/lib/services/__tests__/ad-campaign-credit-reconciliation.test.ts packages/cloud/shared/src/lib/services/__tests__/ad-account-approval.test.ts packages/cloud/shared/src/lib/services/__tests__/ad-inventory.test.ts packages/cloud/shared/src/lib/services/__tests__/ad-tag-token.test.ts → 48 pass / 0 fail
• bun run --cwd packages/cloud/shared typecheck
• bunx @biomejs/biome@2.5.2 check packages/cloud/shared/src/lib/services/__tests__/ad-campaign-credit-reconciliation.test.ts --files-ignore-unknown=true
• git diff --check origin/develop...HEAD && git diff --check

No approval from me because this PR is self-authored by lalalune.

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.