fix(orchestrator): register 404'd task-detail routes + terminal-completed-state evidence (#11028) - #11699
Conversation
… that 404'd over HTTP While driving a real coding task to completion for #11028 evidence, the task- detail pane hung on "Loading task…": the orchestrator UI's fetchDetail does Promise.all([getCodingAgentTaskThread, listOrchestratorTaskTimeline]), and GET /api/orchestrator/tasks/:taskId/timeline 404'd — rejecting the whole fetch so Approve/Reject/Restart controls were unreachable. Root cause: the handlers for timeline, auto-validate, retry-turn, rerun-from-event, restart, restart-with-edited-plan, and plan-revisions exist in api/orchestrator-routes.ts but were never listed in CODING_AGENT_ROUTE_PATHS, which the runtime route matcher needs as exact path templates to reach them. Same class of gap already fixed for credential paths (setup-routes-credential- paths.test.ts); this adds the missing task-scoped templates + a guard test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…eenshots + recording + deliverable (#11028) Closes the gap #11650 left (its task stalled in 'validating'). A real coding task 'Write hello.txt' driven through the live orchestrator on the claude ACP sub-agent reached finalStatus:done: UI shows the green 'done' badge + task/sub- agent completion checks; task-result.json shows artifactsVerified:true, all 3 acceptance criteria met, a live grilling test (wc -c hello.txt = 3 bytes 'hi\n'); backend log shows [swarm-synthesis] '1 completed'; the deliverable hello.txt is committed. Includes the walkthrough .webm + backend/console logs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
2 participants
Two things, found and proven by driving a real coding task end-to-end (the terminal-state evidence gap #11650 left open).
1. Bug fix — task-detail + control routes 404'd over HTTP
Driving a task to completion surfaced that the task-detail pane hangs on "Loading task…". The orchestrator UI's
useOrchestratorData.fetchDetailrunsPromise.all([getCodingAgentTaskThread, listOrchestratorTaskTimeline]), andGET /api/orchestrator/tasks/:taskId/timeline404'd — rejecting the whole fetch, so Approve/Reject/Restart were unreachable.Root cause: the handlers for
timeline,auto-validate,retry-turn,rerun-from-event,restart,restart-with-edited-plan, andplan-revisionsare implemented inapi/orchestrator-routes.ts(verified:sub === "timeline"at :828, etc.) but were never listed inCODING_AGENT_ROUTE_PATHSinsetup-routes.ts, which the runtime route matcher needs as exact templates. Same class of gap already fixed once for credential paths — this adds the 7 missing task-scoped templates + a guard test modeled on the existingsetup-routes-credential-paths.test.ts.bunx turbo build --filter=@elizaos/plugin-agent-orchestrator✅setup-routes-task-detail-paths.test.ts+ sibling: 5 passed.2. Evidence — task reaches terminal
donestate.github/issue-evidence/11028-orchestrator-terminal-state/. Task "Write hello.txt" driven through the live orchestrator on the claude ACP sub-agent (Miya [claude]) reached a verified terminal state:04b-orchestrator-list-done.pngshows the green "● done" badge;04-completed-terminal.pngshows the task + sub-agent completion checks and thehello.txtdeliverable in Changes.logs/task-result.json→finalStatus:"done",artifactsVerified:true, all 3 acceptance criteria met, a live grilling test (wc -c hello.txt= 3 byteshi\\n);logs/backend.log→[swarm-synthesis] … 1 completed.hello.txt(hi\\n) committed.video/orchestrator-terminal-state-walkthrough.webm(4.9 MB), plus browser console log.This is the terminal-completed proof #11650's capture never reached (it stalled in validating).
Refs #11028
🤖 Generated with Claude Code