Skip to content

fix(app): keep plugin audit density within ratchet - #11666

Merged
lalalune merged 2 commits into
developfrom
fix/plugin-audit-density-ratchet
Jul 2, 2026
Merged

fix(app): keep plugin audit density within ratchet#11666
lalalune merged 2 commits into
developfrom
fix/plugin-audit-density-ratchet

Conversation

@lalalune

@lalalune lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Compact the inbox GUI channel filters so the loaded view only shows connected channels, while preserving active selections.
  • Compact the screenshare remote connection controls so mobile portrait stays above the floating chat overlay without dropping actions.
  • Refresh the type-safety ratchet baseline to the current counts after fix: restore type safety ratchet baseline #11594 merged.

Why

While validating #11594, bun run --cwd packages/app audit:app failed the minimalism ratchet for plugin-inbox-gui mobile-landscape and plugin-screenshare-gui mobile-portrait. The merged #11594 branch did not include these layout fixes, so this PR carries them separately.

Validation

  • bun run --cwd packages/app audit:app on rebased head: 349/349 passed; broken=0, minimalism-budget-failures=0, minimalism-ratchet-failures=0, hover-probe-failures=0, density-probe-failures=0.
  • Manual review filled for the touched inbox/screenshare GUI viewports under packages/app/aesthetic-audit-output/manual-review/.
  • bun run audit:type-safety-ratchet passed.
  • bunx @biomejs/biome check --config-path biome.json --files-ignore-unknown=true packages/scripts/type-safety-ratchet-baseline.json plugins/plugin-inbox/src/components/inbox/InboxView.tsx plugins/plugin-screenshare/src/components/ScreenshareSpatialView.tsx passed.
  • git diff --check origin/develop...HEAD passed.

Note: plugin-trajectory-logger-gui mobile-landscape still reports the pre-existing non-blocking needs-work overlay note in the app audit (overlay overlaps "open" (127px²)), but there are no ratchet, hover, density, or broken-view failures.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0c1ed6a2-83b6-42ae-b167-a1456bae4b82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/plugin-audit-density-ratchet

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune
lalalune marked this pull request as ready for review July 2, 2026 23:10

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@lalalune
lalalune merged commit 105b764 into develop Jul 2, 2026
32 of 105 checks passed
@lalalune
lalalune deleted the fix/plugin-audit-density-ratchet branch July 2, 2026 23:30
@lalalune

lalalune commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Same-account review note after local verification. I did not submit an approving review because this PR is authored by lalalune.

Reviewed the related local package guidance (packages/app, plugin-inbox, plugin-screenshare) and the PR diff. The inbox change is scoped to connected-channel filter display while preserving active selected channels; the screenshare change compacts the remote URL/session/token controls without changing session behavior; the type-safety baseline decrease matches the current scanner output.

Verification run on head ef36c0d6e5752d4f82939a45994bbe1cb1e4d064:

  • bun run audit:type-safety-ratchet passed: scanned 10028 files; as unknown as 75/75; non-null assertions 515/515; other ratchets at baseline.
  • Biome check passed for the changed baseline + inbox + screenshare files.
  • git diff --check origin/develop...HEAD passed.
  • bun run --cwd plugins/plugin-screenshare test -- src/components/ScreenshareSpatialView.test.tsx src/components/ScreenshareView.test.tsx passed: 2 files / 12 tests.
  • bun run --cwd plugins/plugin-screenshare build:types passed.
  • bun run --cwd plugins/plugin-inbox typecheck passed after linking worktree-local package deps.
  • bun run --cwd packages/app audit:app passed: 349/349 tests; broken=0; minimalism-budget-failures=0; minimalism-ratchet-failures=0; hover-probe-failures=0; density-probe-failures=0.

Manual screenshot review:

  • plugin-inbox-gui passed mobile portrait, mobile landscape, desktop landscape, and iPad portrait. The mobile connected-channel filters and open buttons are readable and not overlapping.
  • plugin-screenshare-gui passed mobile portrait, mobile landscape, desktop landscape, and iPad portrait. The tightened button/input rows fit their containers; mobile portrait wraps predictably.
  • The single audit needs-work finding is unrelated and pre-existing: plugin-trajectory-logger-gui mobile-landscape, floating composer overlap on the open control.

No blocking issues found.

@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants