test(app): fix 4 first-run e2e specs left red by #11509's runtime-chip removal - #11656
Conversation
#11509) PR #11509 removed the third runtime chip (`runtime:other` = "Bring your own keys") from the in-chat onboarding conductor — it conflated the inference- provider axis with the runtime-location axis. Four ui-smoke specs still asserted that deleted chip is VISIBLE, so they are guaranteed-red on develop: - runtime-configurability.spec.ts - first-run-startup.spec.ts - walkthrough/walkthrough-capture-smoke.spec.ts - walkthrough/journey.ts (step 02) Each now asserts the chip is absent (`toHaveCount(0)`) instead of visible, and the stale header/expectation comments + the IN_CHAT_ONBOARDING_DESIGN.md option list are corrected to the shipped Cloud/Local chooser. The conductor seeds only runtime:cloud + runtime:local (use-first-run-conductor.ts:108-113); BYOK remains reachable as provider:other one step later. The unit tests that assert a stale runtime:other pick is consumed as a no-op are correct and left unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
2 participants
What
PR #11509 ("clean two-option onboarding chooser", commit
d534de09f3) removed the third runtime chip —runtime:other= "Bring your own keys" — from the in-chat first-run conductor, because it put an inference-provider concept on the runtime-location axis. But fourpackages/app/test/ui-smokespecs still assert that chip is visible, so they are guaranteed-red on develop:runtime-configurability.spec.tsfirst-run-startup.spec.tswalkthrough/walkthrough-capture-smoke.spec.tswalkthrough/journey.ts(journey step 02,onboarding-runtime)Each now asserts the chip is absent (
toHaveCount(0)) instead of visible. Stale header/expectation comments and the option list inIN_CHAT_ONBOARDING_DESIGN.mdare corrected to the shipped Cloud / Local chooser.Why it's correct
The live conductor seeds only two runtime chips —
use-first-run-conductor.ts:108-113:BYOK stays reachable one step later as
provider:other("Other / configure in Settings"). The handler atuse-first-run-conductor.ts:480rejects any runtime id other thancloud|local, and the unit tests already assert a staleruntime:otherpick is consumed as a no-op (use-first-run-conductor.test.ts:294,.fuzz.test.ts:157) — those are correct and left unchanged. This PR only aligns the e2e visibility assertions with that shipped behavior.Testing
biome checkclean on all 4 touched specs.toBeVisible()/ locator onchoice-__first_run__:runtime:otheranywhere intest/ui-smoke; the only remaining references are the newtoHaveCount(0)absence checks and the correct no-op unit tests.test:e2erun: N/A in this environment (needs a full app build + browser); the change is a pure test-assertion alignment to already-merged fix(first-run/runtime): clean two-option onboarding chooser + runtime/instance-management hardening #11509 behavior, and the assertion now matches the conductor source cited above. Reviewer CI exercises the specs.Context
Surfaced by an on-device onboarding review: a Pixel 6a running a build from before #11509 merged still shows the old three-option chooser ("Bring your own keys"), which is a stale-build artifact — the fix is on develop but these specs were left red behind it.
Refs #11509
🤖 Generated with Claude Code