chore(scripts): remove 6 verified-dead per-package scripts (#10200) - #11627
Conversation
Fresh de-larp audit of scripts/ + packages/scripts/ + packages/*/scripts + plugins/*/scripts. The larp catch-verifier axis (main().catch(console.error)) is already 0 (fixed in #11548); the 42 `|| true` occurrences are all legitimate best-effort probes/idempotent cleanup; the check-i18n / check-secret-hygiene "dupes" have intentionally diverged for fork vs in-repo invocation. Removed the airtight completed-throwaway subset (each proven 0-reference tree-wide via `git grep -l <basename>`, none test-glob files, none imported): - plugins/plugin-training/scripts/gepa-view-switching.ts - plugins/plugin-training/scripts/multishot-view-switching.ts - packages/app/scripts/android-webview-attach-probe.mjs - packages/benchmarks/social-alpha/trenches-chat-dataset/scripts/monitor_progress.sh - packages/benchmarks/social-alpha/trenches-chat-dataset/scripts/calculate_success_metrics.ts - packages/benchmarks/social-alpha/trenches-chat-dataset/scripts/calculate_realistic_success_metrics.ts Evidence: .github/issue-evidence/10200-scripts-delarp-slice/README.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Same-account review note, not an approval. No findings. I checked the deleted helpers against the package-local docs and the live script surfaces:
Local Windows validation:
No runtime/UI/native surface changes here, so screenshots/video are N/A for my review. |
LifeOps Benchmark —
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
What & why (#10200 de-larp slice)
Fresh audit of
scripts/,packages/scripts/, and the inventory-tool-uncoveredpackages/*/scripts+plugins/*/scriptsfor the issue's three de-larp axes. Pure subtraction — removes 6 airtight verified-dead scripts.Axis results
main().catch(console.error)→ logs but exits 0)|| true(42 occurrences)command -vprobes, idempotentsed/cp,grep -cno-match). No swallowed verify assertion. Deferred per #11548's per-callsite note.check-i18n.mjs/check-secret-hygiene.mjsexist in bothpackages/scripts/andpackages/app-core/scripts/but have diverged (in-repo../..vs forkprocess.cwd()root resolution — intentionally separate). NOT safe to dedupe.Dead scripts removed — each 0 references tree-wide (proven
git grep -l <basename>, none*.test.*, none imported)plugins/plugin-training/scripts/gepa-view-switching.ts— completed GEPA view-switching experiment;package.jsonwiresgepa:view-context/verify:view-switching(kept) but not this. Same class as GEPA one-offs deleted in chore(scripts): #10200 slice — delete 15 verified-dead root scripts, fail loudly on script rejections #11548.plugins/plugin-training/scripts/multishot-view-switching.ts— completed multi-shot-demo finding experiment; unwired.packages/app/scripts/android-webview-attach-probe.mjs— one-time Playwright-Android-attach "de-risk probe"; real harness now exists.packages/benchmarks/social-alpha/trenches-chat-dataset/scripts/monitor_progress.sh— manualwatch-loop helper; README pipeline is onlybuild_dataset.ts+fetch_price_history.ts.packages/benchmarks/social-alpha/trenches-chat-dataset/scripts/calculate_success_metrics.ts— one-time metric analysis; not in README pipeline, not imported bybuild_dataset.ts.packages/benchmarks/social-alpha/trenches-chat-dataset/scripts/calculate_realistic_success_metrics.ts— iterated near-dup of the above.Verification
git grep -l "<basename>"returns only the file itself for all 6.tsconfigfilesarray lists any of them.plugin-trainingretains its wired harnesses; trenches README pipeline untouched.Honest scope note
Prior #10200 slices (#10479, #10681, #11548, #11367) already exhausted the safe dead-script surface in
scripts/+packages/scripts/, fixed all silent-exit 0handlers, and corrected the inventory orphan model. Remaining per-package orphans are overwhelmingly manually-run operator/dev/QA/migration tools (#11367 lesson: hand-run entrypoints are false orphans) and are deliberately left in place. The 6 here are the airtight completed-throwaway subset.Evidence:
.github/issue-evidence/10200-scripts-delarp-slice/README.mdApp/native/screenshot evidence: N/A — repo support-script deletion only, no UI/runtime/native surface.
🤖 Generated with Claude Code