fix(advertising): gate updateCampaign on account approval — close the suspended-account spend leg (#11364)

packages/cloud/shared/src/lib/services/__tests__/ad-account-approval.test.ts

@@ -148,5 +148,14 @@ describe("campaign spend requires an approved (active) account (#11364)", () =>
         /not active/,
       );
     });
+
+    test(`updateCampaign is blocked when account is ${status} (no budget-increase spend)`, async () => {
+      track(spyOn(adCampaignsRepository, "findById").mockResolvedValue(makeCampaign()));
+      track(spyOn(adAccountsRepository, "findById").mockResolvedValue(makeAccount(status)));
+
+      await expect(
+        advertisingService.updateCampaign(CAMPAIGN_ID, ORG_ID, { budgetAmount: 10_000 }),
+      ).rejects.toThrow(/not active/);
+    });
   }
 });

packages/cloud/shared/src/lib/services/advertising/index.ts

@@ -686,6 +686,12 @@
       throw new Error("Ad account not found");
     }
 
+    if (account.status !== "active") {
+      throw new Error(
+        `Ad account is not active (status: ${account.status}); it must be approved before running campaigns`,
+      );
+    }
+
     const credentials = await this.getCredentials(account);
     const provider = this.getProvider(account.platform);