feat(ui/launcher): single read-only page of views (hide developer/preview) + single-owner notifications - #11523
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lalalune
force-pushed
the
shaw/launcher-single-page
branch
from
July 2, 2026 20:18
291bf57 to
e1a95fc
Compare
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
…esture follow-ups) Home-screen e2e passes end-to-end on the rebased tree: mobile sheet + desktop panel render on-screen, read-only launcher, swipe-back returns home, 0 page errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eview by default, drop edit-mode + multi-page The launcher is now ONE page of views (the home dashboard is the adjacent rail page). No more "next page of views" swipe, no sticky/featured header, no edit/reorder machinery. Curation (curateLauncherPages): - Returns a SINGLE page. Ordering: curated apps → developer tools (only when Developer Mode is on) → other loaded apps (alphabetical) → AOSP native tiles. - Visibility now follows the view-kind taxonomy for EVERY tile: system + release always show; developer + preview are hidden by default and appear only when their Settings toggle is on (developer defaults on in dev builds, off in production; preview off everywhere). The curated developer TOOLS (trajectories/ database/runtime/logs/skills/plugins) are treated as developer-kind regardless of how each is declared, so the whole set hides together in production — previously they bypassed the gate and always forced a second "Developer" page. - Native-OS tiles stay AOSP-only (the "system ones that are not native" carve-out on web + the mobile app). Launcher is READ-ONLY: removed edit mode, long-press-to-edit, drag-reorder, per-tile edit/delete, and the entire persisted free-form layout model (launcher-layout reduced to the two sizing constants; reconcile/move/read/write + LauncherLayout type + storage keys + their tests deleted). The store's launcherEditing state + enter/exit/toggle/set setters are gone, and HomeLauncherSurface's dead `|| launcherEditing` gesture/button arms with them. It renders the curated group(s) directly (never chunks), so it is always one vertically-scrolling page; the only gesture it owns is the right-swipe back to home (onEdgeSwipeRight). The outer rail owns the home→launcher direction — one gesture per surface, smooth. Tests/e2e updated for the read-only single-page model (Launcher.test 17, gestures 8, curation 17, LauncherSurface, composed, store 8; launcher-fixture + run-launcher-e2e rewritten — tiles/tap-launch/no-edit-affordances/one-page/ swipe-back-home, screenshots regenerated). 129 launcher/home/store/notification unit tests green; ui typecheck + biome clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… for single-page launcher Two notification shells could stack: HomeScreen rendered its own controlled NotificationCenter AND the app shell mounts the always-on headless owner, each with independent open state. Now HomeScreen's pull-down + pull-zone button just DISPATCH OPEN_NOTIFICATION_CENTER_EVENT; the headless owner is the sole renderer, so the home path and the desktop tray/menu/deep-link path converge on one open state and stacking is structurally impossible. - HomeScreen: drop the local notificationsOpen state + <NotificationCenter> render; dispatchOpenNotificationCenter() on pull-down and on click/keyboard activation. - home-screen e2e fixture: mount the single <NotificationCenter headless /> owner (mirrors App.tsx) so the pull→event→shell flow is exercised end-to-end. - HomeScreen tests: assert the pull/click DISPATCHES the open event (the shell itself is covered by NotificationCenter.test). e2e updated for the single-page read-only launcher: the home-screen-e2e core stub gains real resolveViewKind/isViewKindEnabled (own-keys, so esbuild __toESM exposes them), the developer-tools-on-page-2 + nested-pager-mouse-paging asserts are replaced with single-page asserts (dev tools on page 0 when developer on, no page 2, left-swipe rubber-bands), and the launcher-e2e is read-only (tap-launch + no edit affordances + one page + swipe-back-home). HOME-SCREEN + LAUNCHER e2e PASS; screenshots regenerated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…entries) HomeDashboard.stories + other standalone <Launcher> callers render without pageGroups; default to a single page of every entry so they don't crash (shell-stories-smoke green). LauncherSurface still passes curated groups. Regenerated launcher + home-screen e2e screenshots. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…base The read-only single-page launcher removed edit mode and the longPressTile helper; develop's edit-mode ghost-click suppression suite (auto-merged in on rebase onto develop) tested that deleted behavior and referenced the removed helper. Remove the whole describe block — the launcher no longer has an edit-mode path to guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…t audit Fable audit of the 3 remaining UI dimensions surfaced 12 confirmed in-scope bugs; all fixed here: HIGH - text-2xs / text-3xs / text-xs-tight generated NO CSS: the @theme block registered them under Tailwind v4's WRONG namespace (`--font-size-*` instead of `--text-*`), so 413 usages across packages/ui rendered at inherited size (and call sites had drifted to arbitrary text-[9px]/[11px]). Renamed to `--text-*`; verified via a real @tailwindcss/node 4.3.1 compile probe that the utilities now emit. - Android back never dismissed the notification sheet/panel — it collapsed the chat UNDERNEATH the modal or backgrounded the app. NotificationCenter now registers an ELIZA_BACK_INTENT_EVENT handler while a shell is open (marks the intent handled; covers the bell popover too); ContinuousChatOverlay's back handler gains the same topmost-surface guard its Escape path already had. MEDIUM - Urgent-notification styling was dead CSS (bg-status-error/text-status-error = no token) → bg-status-danger/text-status-danger (the registered tokens). - Launcher grid row gap: portrait:gap-y-14 beat sm:gap-y-5 on tablet-portrait / portrait desktop → 56px gaps. Now max-sm:portrait:gap-y-14 (phone-portrait only), so ≥sm gets the compact 20px gap. - Notification dismiss X was a 22px touch target on the phone sheet → 44px on coarse pointers via the house pointer-coarse:min-*-touch convention (+ row pr bump so it doesn't overlap the body). - Content clearance dropped --android-gesture-inset-bottom while the composer lifts by it → occluded content on Android gesture-nav. App.tsx MOBILE_NAV_PADDING + HomeScreen + LauncherSurface now use max(safe-area-bottom, android-gesture-inset-bottom). - --eliza-continuous-chat-clearance was never set (every surface rode the 5.25rem fallback while a multi-line/attachment composer overgrew it and covered content). The overlay now publishes its RESTING composer height to that var via ResizeObserver (only while collapsed). LOW - Sort toggles: bare `rounded` (4px) → rounded-sm (3px brand token). - Notification z-indexes: z-[9550]/[9560] literals → Z_NOTIFICATION_BACKDROP/ OVERLAY inline styles from floating-layers (single source of truth). - Escape double-dismiss: NotificationCenter now defers Escape to a stacked open Radix dialog (e.g. Cmd+K), peeling one layer per press. - Chat overlay orange literals (#FF5800 / var(--brand-orange)) → text-accent / bg-accent tokens. +4 unit tests (Android-back handled/idle, Escape-defer-to-stacked-dialog). 364 notification/launcher/home/chat tests green; ui typecheck + biome clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… widget gating (4 of 5) Resumed audit (home-widgets dimension) confirmed 5 more; 4 fixed here: HIGH - Home→launcher swipe self-cancelled when it started over the notification pull-strip: lostpointercapture BUBBLES, so the strip button's implicit-capture release fired the pager's onLostPointerCapture (bound on the rail half) and aborted the drag. Guard with target === currentTarget (same fix use-pull-gesture already has); genuine mouse/pen capture loss still has target === currentTarget. MEDIUM - DefaultHomeWidgets returned null on first paint (now === 0) then popped the whole time/weather grid in — a guaranteed CLS on every home mount. Now the grid + time tile render immediately (footprint reserved); only the time TEXT stays `invisible` until the live clock ticks. LOW - isWidgetEnabled: calendar/relationships/workflow ARE backed by real plugins but bypassed the enabled+active gate via the always-visible short-circuit. Consult the snapshot first: an explicit present+disabled plugin now hides its widget; core non-plugin ids (never in the snapshot) still pass untouched. - Notification pull-strip tap-shadowed the top ~30-50px of home content; the home scroller now reserves that band with matching top padding. Deferred (medium): HOME_RENDER_CAP can slice wallet.balance / workflow.running when the declared set exceeds the cap — the fix is per-widget usePublishHomeAttention wiring in those two widget internals (their own preferred fix), out of scope for this UI sweep; it only bites the pathological all-active state. +1 pager unit test (child's bubbled lostpointercapture doesn't self-cancel). 137 pager/home/widget/registry tests green; ui typecheck + biome clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…fixes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lalalune
force-pushed
the
shaw/launcher-single-page
branch
from
July 2, 2026 20:51
82c6595 to
0c51746
Compare
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This was referenced Jul 2, 2026
lalalune
pushed a commit
that referenced
this pull request
Jul 3, 2026
…r gate, 5 coverage-ratchet drifts, deterministic #11030 deadlock guard packages/ui no-backdrop-blur-gate (#9141 battery): #11829's new NotificationCenter reintroduced backdrop-blur-2xl/backdrop-saturate-150 on the sheet/panel shell. Drop the GPU backdrop filter and carry readability with a near-opaque base (bg-neutral-950/[0.87]) instead; refresh the committed home-screen e2e artifacts (sheet + panel verified readable over the live launcher in headless chromium, 10 screenshots + walkthrough video). packages/app coverage/ratchet gates (5 reds, all real drift, no baselines loosened): - core-view-action-surface + view-switching matrices: track the automations core view (added by b07f3d9 without a surface owner) and the background settings subsection (#10994 registered it in SETTINGS_SECTION_META only) — AutomationsFeed + BackgroundSettings* are real agent-surface owners. - route-coverage: plugin-birdclaw (#11385) declares a production collapsed gui/xr/tui view that was never added to the manifest ratchet. Wire it fully: manifest list, XR ratchet, runtime-plugin boot classification, gui+tui visual-matrix cases, tracked visual-review rows, manager-visible tile case, HMR lockstep probe, GUI interaction owners (its real plugin.test.ts + BirdclawView.test.tsx), and the ui-smoke stub (view registration + honest zero-key /api/birdclaw/status "not installed" state). Both birdclaw Playwright visual cases pass live (real BirdclawView bundle renders the setup card; audit JSON + screenshots reviewed). - ui-smoke-coverage: scenario-pr.yml still hand-named the 10 pre-#11442 voice-workbench spec filenames; point the slice at the renamed specs. - view-interaction-coverage: the launcher owner declaration still claimed edit-mode/drag-to-reorder coverage that #11523's read-only launcher removed; declare what run-launcher-e2e.mjs actually proves now (no-edit long-press, tap-launch telemetry). ios-local-agent-transport #11030 deadlock guard (both ui + app-core copies, ~1-in-4 flaky under a loaded suite): the 10s wall-clock Promise.race lost to a CPU-starved event loop. Replace it with a deterministic detector — promise assimilation invoking the hostile proxy's fabricated `then` proves the raw Capacitor proxy crossed an await (the exact #11030 regression) and rejects instantly with the descriptive error. Verified: reintroducing the raw-proxy bug fails the test immediately with the #11030 message; fixed transport never touches `then` (asserted). Suites: packages/ui 544 files / 5532 pass; packages/app 37 files / 316 pass; app-core transport suite 30 pass; typecheck green (ui, app, app-core); biome clean on touched files.
lalalune
pushed a commit
that referenced
this pull request
Jul 3, 2026
…r gate, 5 coverage-ratchet drifts, deterministic #11030 deadlock guard (#11898) packages/ui no-backdrop-blur-gate (#9141 battery): #11829's new NotificationCenter reintroduced backdrop-blur-2xl/backdrop-saturate-150 on the sheet/panel shell. Drop the GPU backdrop filter and carry readability with a near-opaque base (bg-neutral-950/[0.87]) instead; refresh the committed home-screen e2e artifacts (sheet + panel verified readable over the live launcher in headless chromium, 10 screenshots + walkthrough video). packages/app coverage/ratchet gates (5 reds, all real drift, no baselines loosened): - core-view-action-surface + view-switching matrices: track the automations core view (added by b07f3d9 without a surface owner) and the background settings subsection (#10994 registered it in SETTINGS_SECTION_META only) — AutomationsFeed + BackgroundSettings* are real agent-surface owners. - route-coverage: plugin-birdclaw (#11385) declares a production collapsed gui/xr/tui view that was never added to the manifest ratchet. Wire it fully: manifest list, XR ratchet, runtime-plugin boot classification, gui+tui visual-matrix cases, tracked visual-review rows, manager-visible tile case, HMR lockstep probe, GUI interaction owners (its real plugin.test.ts + BirdclawView.test.tsx), and the ui-smoke stub (view registration + honest zero-key /api/birdclaw/status "not installed" state). Both birdclaw Playwright visual cases pass live (real BirdclawView bundle renders the setup card; audit JSON + screenshots reviewed). - ui-smoke-coverage: scenario-pr.yml still hand-named the 10 pre-#11442 voice-workbench spec filenames; point the slice at the renamed specs. - view-interaction-coverage: the launcher owner declaration still claimed edit-mode/drag-to-reorder coverage that #11523's read-only launcher removed; declare what run-launcher-e2e.mjs actually proves now (no-edit long-press, tap-launch telemetry). ios-local-agent-transport #11030 deadlock guard (both ui + app-core copies, ~1-in-4 flaky under a loaded suite): the 10s wall-clock Promise.race lost to a CPU-starved event loop. Replace it with a deterministic detector — promise assimilation invoking the hostile proxy's fabricated `then` proves the raw Capacitor proxy crossed an await (the exact #11030 regression) and rejects instantly with the descriptive error. Verified: reintroducing the raw-proxy bug fails the test immediately with the #11030 message; fixed transport never touches `then` (asserted). Suites: packages/ui 544 files / 5532 pass; packages/app 37 files / 316 pass; app-core transport suite 30 pass; typecheck green (ui, app, app-core); biome clean on touched files.
Contributor
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The launcher is now one read-only page of views (the home dashboard is the adjacent rail page), with developer/preview views hidden by default. Removes the multi-page "next page of views" swipe, the sticky/featured header, and all edit/reorder machinery the user called out.
Stacked on #11316 (notification a11y/gesture follow-ups) — that PR's commits appear here until it merges.
Launcher structure
curateLauncherPagesreturns a single page: curated apps → developer tools (only when Developer Mode is on) → other loaded apps → AOSP native tiles.system+releasealways show;developer+previewhidden by default, shown only via their Settings toggle (developer defaults on in dev builds / off in production; preview off everywhere). The curated developer tools (trajectories/database/runtime/logs/skills/plugins) are treated as developer-kind so the whole set hides together — previously they bypassed the gate and forced a permanent second page.Read-only launcher (dead-code removal)
launcher-layoutreduced to the two sizing constants; reconcile/move/read/write + type + storage + their tests deleted).launcherEditingstate + enter/exit/toggle/set setters, andHomeLauncherSurface's dead|| launcherEditinggesture/button arms.Notifications — single-owner (the 2nd deferred item from #11316)
OPEN_NOTIFICATION_CENTER_EVENT; the always-mounted headless NotificationCenter is the sole renderer, so two shells can never stack.Tests / evidence
packages/uitypecheck + biome clean.output-launcher/mobile-rest.pngshows the clean single page).chat-stories-smokewidgetplay()timeouts (model-download/needs-attention/calendar/finances/etc.) — outside this diff, unreachable from these changes (that glob only loadschat/**stories), and develop already has a "model-download story mock-fetch timing" fix commit in this area.🤖 Generated with Claude Code
Follow-up: full 3-dimension UI audit (16 more verified bugs, 15 fixed)
A fable audit of the remaining UI dimensions (responsive/brand, chat-overlay, home-widgets) surfaced 16 confirmed in-scope bugs on top of the launcher redesign; 15 fixed here:
text-2xs/text-3xs/text-xs-tightgenerated NO CSS (registered under Tailwind v4's wrong--font-size-*namespace instead of--text-*): 413 usages acrosspackages/uirendered at inherited size. Renamed; verified the utilities now emit via a real@tailwindcss/nodecompile probe.lostpointercapture) →target === currentTargetguard.status-error→status-danger), launcherportrait:gap-y-14cascade (→max-sm:portrait), dismiss-X 22→44px touch target,--android-gesture-inset-bottomclearance occlusion,--eliza-continuous-chat-clearancepublished from the real composer height, DefaultHomeWidgets first-paint CLS.rounded→rounded-sm, notification z-index viaZ_NOTIFICATION_*constants, Escape defers to stacked Radix dialogs, chat-overlay orange literals→text-accent,isWidgetEnabledgate for calendar/relationships/workflow, notification pull-strip content-shadow padding.One deferred (medium, documented):
HOME_RENDER_CAPcan slicewallet.balance/workflow.running— the fix is per-widgetusePublishHomeAttentionwiring in those widget internals, out of scope for this UI sweep.+9 unit tests added across the two rounds. Full
packages/uitypecheck + biome clean; launcher-e2e + home-screen-e2e PASS.