fix(feed,benchmarks): restore 7 files clobbered by #11271 — broken imports + orphaned tests (#11419)

[0xSolace]

What

Restores the 7 packages/feed + packages/benchmarks files clobbered by the #11271 stale-base mega-revert, per the blob-level audit on #11419. All 7 restored byte-identical from the pre-clobber parent dc1a63b103 (= 5b714c74e6^), then verified against the current develop tip. One post-restore fix from codex review (see below).

Per-file breakdown

🔴 Live functional breakage on develop

1. packages/benchmarks/orchestrator_lifecycle/events.py

• runner.py:228 calls extract_lifecycle_events(actions, params) from .events (import at runner.py:37). The module was deleted, so the bench dies at import time.
• Verified: python3 -c "from benchmarks.orchestrator_lifecycle import runner" → OK after restore (ImportError before).

2. packages/feed/tools/e2e-gate.mjs

• Both packages/feed/tools/chroma/package.json and packages/feed/tools/e2e/package.json invoke node ../e2e-gate.mjs --suite ... -- <playwright cmd> in their test scripts. The gate script was deleted, so both lanes die at spawn — and the whole point of this script was making skipped lanes VISIBLE (FEED_E2E_RESULT=skipped, exit 3 under CI/strict) instead of silently exiting 0.
• Verified: node --check clean; CLI args in both package.json scripts match the gate's --suite/--requires/-- interface.

3. packages/feed/tools/chroma/specs/helpers/page-helpers.health.test.ts
4. packages/feed/tools/e2e/tests/helpers/page-helpers.health.test.ts

• Referenced by each package's test:unit script (bun test <path>); scripts pointed at deleted files.

🟡 Orphaned test coverage

5. packages/benchmarks/orchestrator_lifecycle/tests/test_events.py — tests for the extractor above (action-name mapping, pattern-C TASKS operation params, trajectory-snapshot leak guard, prose-produces-no-events).
6. packages/benchmarks/interrupt-bench/tests/honest-scoring.test.ts — the #9310 §3.11 honest-scoring guard.
7. packages/benchmarks/three-agent-dialogue/__tests__/verification.test.ts — computeVerification/detectEmotionFromText coverage; imports still resolve against current runner/verification.ts exports.

Post-restore fix (codex review finding)

Codex review (gpt-5.5) flagged a real gap in the restored extractor: the runtime's actual TASKS control op carries the child operation in controlAction (action=control, controlAction=pause|resume|stop|continue|reopen, per packages/core/src/generated/action-docs.ts), which wasn't in _OPERATION_KEYS — so genuine pause/resume turns would score as missing behavior. Added controlaction to the key set (keys now matched case-insensitively) + 2 regression tests. Second commit, kept separate from the byte-identical restore.

Verification

• python3 -m pytest packages/benchmarks/orchestrator_lifecycle/tests/ -q → 26 passed (incl. 5+2 in test_events.py)
• bun test specs/helpers/page-helpers.health.test.ts (chroma) → 7 pass, 0 fail
• bun test tests/helpers/page-helpers.health.test.ts (e2e) → 7 pass, 0 fail
• bun x vitest run tests/honest-scoring.test.ts (interrupt-bench) → 4 passed
• bun x vitest run __tests__/verification.test.ts (three-agent-dialogue) → 5 passed
• node --check packages/feed/tools/e2e-gate.mjs → clean
• bun x biome check on the 5 touched TS/MJS files → clean, no fixes

Closes the feed + benchmarks rows of the #11419 audit. Does not touch any other rows.

— [sol-orch]

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca389c3a-4d62-4a85-a74b-8a644d643fb1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sol/11419-restore-feed-benchmarks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[github-actions]

❌ PR title does not match the required pattern. Please use one of these formats:

• 'type: description' (e.g., 'feat: add new feature')
• 'type(scope): description' (e.g., 'chore(core): update dependencies')
  Valid types: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert, release

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.