fix(ui,app): #11174 review follow-ups — no-dock launcher spec + notification-panel Escape deferral

[lalalune]

PR #11174 was reviewed MERGE-WITH-FIX with exactly two required fixes, but it was squash-merged (188b73e) before they landed. This follow-up applies both:

1. launcher-interaction.spec.ts updated to the no-dock contract

The keyless-CI-denylisted spec still asserted the removed featured-views dock (launcher-dock visible, chat/settings docked and absent from page 0, dockTiles.slice(0,2) == [chat, settings]). Rewritten against the launcher code as merged:

• asserts launcher-dock has count 0 (contract enforced in Launcher.test.tsx/LauncherSurface.test.tsx and run-home-screen-e2e.mjs too);
• Chat + Settings are ordinary page tiles at the head of curated page 0 (launcher-curation.ts APPS_PAGE_ORDER = ["chat", "settings", …], curated groups passed via pageGroups);
• chat launches by tapping its page tile; the swipe helper is now bidirectional (next/prev, 50%-threshold pointer swipe with launcher-pager-edge-* fallback) so the test returns to page 0 first — inactive pages are inert;
• evidence dir/framing renamed 9144-default-launcher-dock → 9144-launcher-page-tiles.

2. Escape deferral for the desktop anchored notification panel

ContinuousChatOverlay.tsx Escape-collapse guard matched [data-testid="notification-sheet"] but not the new [data-testid="notification-panel"] (role="dialog", no data-state="open" — not Radix), so Escape with the panel open over an open chat sheet closed both. Added the panel testid to the selector and a unit test mirroring the existing transcript-viewer deferral test (renders overlay, mounts a notification-panel dialog, asserts Escape leaves the sheet open, then collapses once the panel is gone).

Verification

• bun run --cwd packages/ui test -- ContinuousChatOverlay.test.tsx — 124 passed (incl. new test)
• bun run --cwd packages/ui test -- Launcher.test.tsx LauncherSurface.test.tsx Launcher.gestures.test.tsx NotificationCenter.test.tsx HomeLauncherSurface.composed.test.tsx — 56 passed
• packages/ui + packages/app typecheck: only 2 pre-existing errors unrelated to this change (@stwd/sdk 0.8.1/0.11.0 duplication in cloud-ui auth, missing iwer types in spatial __e2e__) — present on develop tip.
• Biome check clean on the three touched files.
• The Playwright spec is deny-listed off the keyless PR CI gate per the review; assertions were validated by reading Launcher.tsx, LauncherSurface.tsx, launcher-curation.ts, useHorizontalPager.ts, and PagerEdgeButtons.tsx as merged.

🤖 Generated with Claude Code

[greptile-apps]

Your trial has ended. Reactivate Greptile to resume code reviews.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 180f77a8-720e-4277-bbc4-3473ceff3288

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/pr-11174-followups

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

❌ PR title does not match the required pattern. Please use one of these formats:

• 'type: description' (e.g., 'feat: add new feature')
• 'type(scope): description' (e.g., 'chore(core): update dependencies')
  Valid types: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert, release

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.