Skip to content

fix(ui): dedupe controlled launcher dock tiles - #10834

Merged
lalalune merged 1 commit into
developfrom
fix/9144-controlled-dock-dedupe
Jul 1, 2026
Merged

lalalune merged 1 commit into
developfrom
fix/9144-controlled-dock-dedupe

Conversation

@lalalune

@lalalune lalalune commented Jul 1, 2026

Copy link
Copy Markdown
Member

Follow-up to #10800 / #9144.

Summary

  • Filters the final launcher page list against the rendered dock set, so controlled favoriteIds from desktop-tab pins do not duplicate as page tiles.
  • Extends the controlled-favorites component test to assert the 4-tile dock cap and that docked ids are absent from the page grid while non-docked ids remain.

Evidence

bunx biome check packages/ui/src/components/pages/Launcher.tsx packages/ui/src/components/pages/Launcher.test.tsx
bun run --cwd packages/ui test -- src/components/pages/Launcher.test.tsx src/state/launcher-layout.test.ts src/state/launcher-layout.property.test.ts --coverage.enabled=false
bun run --cwd packages/ui typecheck
bun install

Results:

  • Biome: clean.
  • Focused tests: 49 passed.
  • packages/ui typecheck: passed.
  • bun install: completed with no tracked changes.

Repo-wide verify note: #10800 already documents the current upstream audit:type-safety-ratchet baseline failure on develop; this follow-up only touches the launcher UI component/test and was validated with the focused gates above.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a02bd21d-6df2-4434-867f-e7b5a2091494

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/9144-controlled-dock-dedupe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune
lalalune merged commit 4872447 into develop Jul 1, 2026
34 of 60 checks passed
@lalalune
lalalune deleted the fix/9144-controlled-dock-dedupe branch July 1, 2026 17:24
@github-actions github-actions Bot added the ui label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant