fix(ui): dedupe controlled launcher dock tiles - #10834
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #10800 / #9144.
Summary
favoriteIdsfrom desktop-tab pins do not duplicate as page tiles.Evidence
bunx biome check packages/ui/src/components/pages/Launcher.tsx packages/ui/src/components/pages/Launcher.test.tsx bun run --cwd packages/ui test -- src/components/pages/Launcher.test.tsx src/state/launcher-layout.test.ts src/state/launcher-layout.property.test.ts --coverage.enabled=false bun run --cwd packages/ui typecheck bun installResults:
packages/uitypecheck: passed.bun install: completed with no tracked changes.Repo-wide verify note: #10800 already documents the current upstream
audit:type-safety-ratchetbaseline failure ondevelop; this follow-up only touches the launcher UI component/test and was validated with the focused gates above.