Fix ci #226
Merged
Fix ci #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabrielperales
commented
Jul 8, 2024
•
gabrielperales
commented
- Update the minimum elixir version due to ecto (it needs at least elixir 1.11)
- Make CI run on PR targeting master branch.
Nitrino
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
@gabrielperales Thank for your contribution.
Later I will do a review of the library dependencies due to these changes, I think we may stop supporting some of the older versions, for example Ecto up to version 3+.
.github/workflows/ci.yml
Outdated
Comment on lines
1
to
5
| on: | ||
| push: | ||
| pull_request: | ||
| branches: [master] | ||
| types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
It seems to me we can just run CI on any PR
Suggested change
| on: | |
| push: | |
| pull_request: | |
| branches: [master] | |
| types: [opened, synchronize, reopened] | |
| on: | |
| pull_request: |
There was a problem hiding this comment.
I think the CI badge is not working properly after removing on: push 😓
There was a problem hiding this comment.
@gabrielperales No problem. I would fix them
Nitrino
reviewed
Jul 8, 2024
Co-authored-by: Petr Stepchenko <[email protected]>
grzuy
reviewed
Jul 10, 2024
| @@ -1,4 +1,5 @@ | |||
| on: push | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
Note that removing push here made it so that now it doens't run CI on master branch, only pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.