Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module.function notation warnings in Elixir 1.17 #123

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

sabiwara
Copy link
Contributor

@sabiwara sabiwara commented Jun 5, 2024

Fixes the following warnings in Elixir 1.17:

warning: using map.field notation (without parentheses) to invoke function WaffleTest.Actions.Store.DummyDefinition.async() is deprecated, you must add parentheses instead: remote.function()
  (waffle 1.1.8) lib/waffle/actions/store.ex:82: Waffle.Actions.Store.put_versions/2
  (waffle 1.1.8) lib/waffle/actions/store.ex:70: Waffle.Actions.Store.put/2
  test/actions/store_test.exs:232: WaffleTest.Actions.Store."test accepts remote files with spaces"/1
  (ex_unit 1.17.0-rc.0) lib/ex_unit/runner.ex:485: ExUnit.Runner.exec_test/2
  (stdlib 6.0) timer.erl:590: :timer.tc/2
  (ex_unit 1.17.0-rc.0) lib/ex_unit/runner.ex:407: anonymous fn/6 in ExUnit.Runner.spawn_test_monitor/4

warning: using map.field notation (without parentheses) to invoke function WaffleTest.Actions.Store.DummyDefinition.__storage() is deprecated, you must add parentheses instead: remote.function()
  (waffle 1.1.8) lib/waffle/actions/store.ex:136: Waffle.Actions.Store.put_version/3
  (elixir 1.17.0-rc.0) lib/task/supervised.ex:101: Task.Supervised.invoke_mfa/2
  (elixir 1.17.0-rc.0) lib/task/supervised.ex:36: Task.Supervised.reply/4

...

The first commit ships this fix deadtrickster/ssl_verify_fun.erl#27 which is needed to run tests locally on Elixir 1.15+.

@achempion achempion merged commit 69b49c3 into elixir-waffle:master Jun 6, 2024
1 check passed
@achempion
Copy link
Member

Thanks 👍

@sabiwara sabiwara deleted the elixir-1.17 branch June 6, 2024 10:04
@odarriba
Copy link

Any chance to get at new release with this change? For early updaters it is causing several runtime warnings 😅

Thanks!

@achempion
Copy link
Member

@odarriba done

@odarriba
Copy link

Wow that was quick. Thanks a lot <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants