chore(nix): updates to use nixpkgs elixir 1.17 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/57d6973abba7ea108bac64ae7629e7431e0199b6' (2024-06-12)
→ 'github:NixOS/nixpkgs/a71e967ef3694799d0c418c98332f7ff4cc5f6af' (2024-06-22)
adamcstephens
changed the title
adamcstephens
force-pushed
the
flake/202306
branch
from
e36449d
to
ccb3802
Compare
mhanberg
reviewed
Jun 26, 2024
something is broken in nixpkgs for zig 0.11 right now, which we need, so we can't do that yet. You'll also have to change the |
mhanberg
approved these changes
Jun 27, 2024
adamcstephens
force-pushed
the
flake/202306
branch
from
ccb3802
to
29777b5
Compare
|
I think this should be good to go, unless you still wanted me to remove the rebar overrides. |
|
I checked out the branch locally and as my shell was booting up nix develop, its running the the rebar tests. still better than before, will merge once i get a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split the package out here, and dropped the makeOverridable. I can put this back if needed, but I think separating the package makes it clearer to reason about. It's also more similar to a nixpkgs package this way. :)
I discovered that erlang_27 actually depends on erlang_26 currently for ex_doc, so you have to compile both with beam_minimal. Anybody using your cache won't notice though.
I also wondered if the zig pinned release could be removed in favor of current unstable.